1593018 - The Sponsored card and Text Promo are wrongly dismissed when any Dismiss/ Save to Pocket, Bookmark actions are taken

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Andreea Cupsa [:acupsa], Experiments QA]

[Affected versions]:

• Firefox Beta 71.0b5, Build ID: 20191028110005
• Firefox Nightly 72.0a1, Build ID: 20191031095309

[Affected Platforms]:

• All Windows
• All Mac
• All Linux

[Prerequisites]:

• Have the following preferences set:
• browser.search.region to US
• browser.newtabpage.activity-stream.asrouter.devtoolsEnabled to true
• browser.newtabpage.activity-stream.discoverystream.enabled to true
• browser.newtabpage.activity-stream.discoverystream.endpoints to https://,http://
• browser.newtabpage.activity-stream.discoverystream.config to
  {"api_key_pref":"extensions.pocket.oAuthConsumerKey","collapsible":true,"enabled":true,"show_spocs":true,"hardcoded_layout":false,"personalized":false,"layout_endpoint":"https://5ad1b408-b40a-4a49-b6ec-27473d192df0.mock.pstmn.io"}

[Steps to reproduce]:

1. Open the browser with the profile from the prerequisites.
2. Open a new tab.
3. Click the Context Menu button from any top site.
4. Click on the Dismiss button.
5. Observe the Sponsored Top Site and Text Promo section.

[Expected result]:

• The Sponsored Top Site and Text Promo section are still displayed.

[Actual result]:

• The Sponsored Top Site and Text Promo section are no longer displayed.

[Regression Range]:

• Due to the fact that this issue is not reproducible on Firefox Release 70 I ran a regression range and reached the following pushlog:
  13:32.98 INFO: Last good revision: 102a90da3f92f85cd04fdc4962ab33a26048ee70
  13:32.98 INFO: First bad revision: 98f2e390e85dc1574d294026aafcbb1e779f816e
  13:32.98 INFO: Pushlog:
  https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=102a90da3f92f85cd04fdc4962ab33a26048ee70&tochange=98f2e390e85dc1574d294026aafcbb1e779f816e

It looks like this issue was introduced with this export.

[Notes]:

• This issue is reproducible when taking any of the following actions:
• Dismissing any card from the Topsite, Recommended by Pocket and Highlights section
• Bookmarking any card from the Recommended by Pocket and Highlights section
• Saving to Pocket any card from the Recommended by Pocket and Highlights section
• Bookmarking or removing a bookmark from any other website while not being on the about:newtab page.
• Bookmarking or removing a bookmark from any other website while not being on the about:newtab page.
• I haven't been able to check if this behavior is also reproducible for the Archive to Pocket, Save to Pocket and Remove Bookmark actions as I encountered this issue where the status of the card is lost after a restart.
• Attached a screen recording with the issue.

@Ed, could you please take a look at this?

Comment 1

[Jessilyn Davis]

NI'ing Scott to look into it too. Thanks y'all!

Comment 2

[Scott [:thecount] Downe]

Got a fix incoming. Thanks for finding this!

Comment 3

[Scott [:thecount] Downe]

[Tracking Requested - why for this release]:

Comment 4

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/5368

Comment 5

[Scott [:thecount] Downe]

[Tracking Requested - why for this release]: Bug blocks future experiments for potential revenue features.

Comment 6

[Julien Cristau [:jcristau]]

When should we expect this change to merge to central?

Comment 7

[Scott [:thecount] Downe]

I'm hoping to have the export request in today.

Comment 8

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/40a815ecfbe3

Comment 9

[Ed Lee :Mardak]

This is in nightly now and someone will request uplift after verification

Comment 10

[Andreea Cupsa [:acupsa], Experiments QA]

I have verified this issue and is no longer reproducible on the Latest Firefox Nightly 72.0a1 (Build ID: 20191110095330) on Windows 10 x64, Mac 10.14.6 and Arch Linux.
I have verified that the "Text Promo" section and the sponsored Top Site is not dismissed when taking the following actions:

• Dismissing any card from the Topsite, Recommended by Pocket and Highlights section.
• Bookmarking any card from the Recommended by Pocket and Highlights section.
• Saving to Pocket any card from the Recommended by Pocket and Highlights section.
• Bookmarking or removing a bookmark from any other website while not being on the about:newtab page.
• Bookmarking or removing a bookmark from any other website while not being on the about:newtab page.

Comment 11

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/5375

Comment 12

[Scott [:thecount] Downe]

Attachment: Bug 1593018 - The Sponsored card and Text Promo are wrongly dismissed when any Dismiss/ Save to Pocket, Bookmark actions are taken

Comment 13

[Scott [:thecount] Downe]

Comment on attachment 9108489 [details]
Bug 1593018 - The Sponsored card and Text Promo are wrongly dismissed when any Dismiss/ Save to Pocket, Bookmark actions are taken

Beta/Release Uplift Approval Request

• User impact if declined: Potential revenue loss from non intended sponsored content dismissal.

• Is this code covered by automated tests?: Yes

• Has the fix been verified in Nightly?: Yes

• Needs manual test from QE?: Yes

• If yes, steps to reproduce:
  [Prerequisites]:

  Have the following preferences set:
  browser.search.region to US
  browser.newtabpage.activity-stream.asrouter.devtoolsEnabled to true
  browser.newtabpage.activity-stream.discoverystream.enabled to true
  browser.newtabpage.activity-stream.discoverystream.endpoints to https://,http://
  browser.newtabpage.activity-stream.discoverystream.config to
  {"api_key_pref":"extensions.pocket.oAuthConsumerKey","collapsible":true,"enabled":true,"show_spocs":true,"hardcoded_layout":false,"personalized":false,"layout_endpoint":"https://5ad1b408-b40a-4a49-b6ec-27473d192df0.mock.pstmn.io"}

[Steps to reproduce]:
Open the browser with the profile from the prerequisites.
Open a new tab.
Click the Context Menu button from any top site.
Click on the Dismiss button.
Observe the Sponsored Top Site and Text Promo section.
[Expected result]:
The Sponsored Top Site and Text Promo section are still displayed.
[Actual result]:
The Sponsored Top Site and Text Promo section are no longer displayed.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's 1 line and been verified and was caused by a regression (so it was, before the regression, already shipped)
• String changes made/needed: none

Comment 14

[Pascal Chevrel:pascalc]

Comment on attachment 9108489 [details]
Bug 1593018 - The Sponsored card and Text Promo are wrongly dismissed when any Dismiss/ Save to Pocket, Bookmark actions are taken

P1, has tests and was verified by QA on Nightly, uplift approved for 71 beta 11, thanks.

Comment 15

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/636d3edd668b

Comment 16

[Andreea Cupsa [:acupsa], Experiments QA]

I have verified this issue and is no longer reproducible on the Latest Firefox Beta 71.0b11 (Build ID: 20191118154140) on Windows 10 x64, Mac 10.14.6 and Debian 9.
I have verified that the "Text Promo" section and the sponsored Top Site is not dismissed when taking the following actions:

• Dismissing any card from the Topsite, Recommended by Pocket and Highlights section.
• Bookmarking any card from the Recommended by Pocket and Highlights section.
• Saving to Pocket any card from the Recommended by Pocket and Highlights section.
• Bookmarking or removing a bookmark from any other website while not being on the about:newtab page.
• Bookmarking or removing a bookmark from any other website while not being on the about:newtab page.