Bug 1598955 Comment 4 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
The "funny" thing is: 2 days later my unchanged webextension button seems to use now the first CSS rule 

´´´
.toolbarbutton-1 .toolbarbutton-icon {
  width: 18px;
  height: 18px;
}
´´´´

instead of the prior used CSS rule:

´´´
.webextension-action > .toolbarbutton-badge-stack > .toolbarbutton-icon {
  height: 16px;
  width: 16px;
}
´´´

And the button size seems to be fixed without your patch (in my test profiles for Tb Daily and Tb Beta), which is in yesterdays comm-central build. In my test profile for Tb 68.2.2 the button icon is still to small and not fixed in a "magical" way.

Nevertheless, the patch seems to be correct and necessary to be checked-in for comm-beta and comm-esr.
Revision 1 by
on 
The "funny" thing is: 2 days later my unchanged webextension button seems to use now the first CSS rule 

```
.toolbarbutton-1 .toolbarbutton-icon {
  width: 18px;
  height: 18px;
}
```

instead of the prior used CSS rule:

```
.webextension-action > .toolbarbutton-badge-stack > .toolbarbutton-icon {
  height: 16px;
  width: 16px;
}
```

And the button size seems to be fixed without your patch (in my test profiles for Tb Daily and Tb Beta), which is in yesterdays comm-central build. In my test profile for Tb 68.2.2 the button icon is still to small and not fixed in a "magical" way.

Nevertheless, the patch seems to be correct and necessary to be checked-in for comm-beta and comm-esr.
Revision 2 by
on 
The "funny" thing is: 2 days later my unchanged webextension button seems to use now the first CSS rule 

``` css
.toolbarbutton-1 .toolbarbutton-icon {
  width: 18px;
  height: 18px;
}
```

instead of the prior used CSS rule:

``` css
.webextension-action > .toolbarbutton-badge-stack > .toolbarbutton-icon {
  height: 16px;
  width: 16px;
}
```

And the button size seems to be fixed without your patch (in my test profiles for Tb Daily and Tb Beta), which is in yesterdays comm-central build. In my test profile for Tb 68.2.2 the button icon is still to small and not fixed in a "magical" way.

Nevertheless, the patch seems to be correct and necessary to be checked-in for comm-beta and comm-esr.

Back to Bug 1598955 Comment 4