Closed Bug 1598955 Opened 3 months ago Closed 3 months ago

width and hight to small for WX toolbar icons in messenger.css

Categories

(Thunderbird :: Add-Ons: General, defect)

defect
Not set

Tracking

(thunderbird_esr68 fixed, thunderbird71 affected, thunderbird72 fixed)

RESOLVED FIXED
Thunderbird 72.0
Tracking Status
thunderbird_esr68 --- fixed
thunderbird71 --- affected
thunderbird72 --- fixed

People

(Reporter: Alex_Ihrig, Assigned: Paenglab)

Details

Attachments

(1 file)

In messenger.css is the size for toolbar buttons:

.toolbarbutton-1 .toolbarbutton-icon {
  width: 18px;
  height: 18px;
}

But the size for WX browserActions is:

/* Rules to help integrate WebExtension buttons */

.webextension-action > .toolbarbutton-badge-stack > .toolbarbutton-icon {
  height: 16px;
  width: 16px;
}

The resulting WX icons size is 16 (16 px - 2x1 px padding = 14 px) instead of 18 px (18 px - 2x1 px padding = 16 px).

Not sure about the right component. Maybe paenglab is the right person?

Flags: needinfo?(richard.marti)
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Flags: needinfo?(richard.marti)
Attachment #9111370 - Flags: review?(geoff)
Attachment #9111370 - Flags: review?(geoff) → review+

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/2b3dd54098bf
Set the webextension icon to the same dimensions as the built-in icons. r=darktrojan

Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Attachment #9111370 - Flags: approval-comm-esr68?
Attachment #9111370 - Flags: approval-comm-beta?
Target Milestone: --- → Thunderbird 72.0
Attachment #9111370 - Flags: approval-comm-beta? → approval-comm-beta+

The "funny" thing is: 2 days later my unchanged webextension button seems to use now the first CSS rule

.toolbarbutton-1 .toolbarbutton-icon {
  width: 18px;
  height: 18px;
}

instead of the prior used CSS rule:

.webextension-action > .toolbarbutton-badge-stack > .toolbarbutton-icon {
  height: 16px;
  width: 16px;
}

And the button size seems to be fixed without your patch (in my test profiles for Tb Daily and Tb Beta), which is in yesterdays comm-central build. In my test profile for Tb 68.2.2 the button icon is still to small and not fixed in a "magical" way.

Nevertheless, the patch seems to be correct and necessary to be checked-in for comm-beta and comm-esr.

You are probably experiencing bug 1599275.

Comment on attachment 9111370 [details] [diff] [review]
1598955-WE-icon-dimension.patch

Missed TB 71 beta 4 for some reason.
Attachment #9111370 - Flags: approval-comm-beta+
Comment on attachment 9111370 [details] [diff] [review]
1598955-WE-icon-dimension.patch

Yes we wanted to wait for the next beta. Let's keep the flags so it doesn't miss that.
Attachment #9111370 - Flags: approval-comm-beta+
Comment on attachment 9111370 [details] [diff] [review]
1598955-WE-icon-dimension.patch

Ah, then it's already there....
Attachment #9111370 - Flags: approval-comm-beta+
Attachment #9111370 - Flags: approval-comm-esr68? → approval-comm-esr68+
You need to log in before you can comment on or make changes to this bug.