1598955 - width and hight to small for WX toolbar icons in messenger.css

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: General, defect)

Description

[Alex Ihrig [:Thunderbird_Mail_DE]]

In messenger.css is the size for toolbar buttons:

.toolbarbutton-1 .toolbarbutton-icon {
  width: 18px;
  height: 18px;
}

But the size for WX browserActions is:

/* Rules to help integrate WebExtension buttons */

.webextension-action > .toolbarbutton-badge-stack > .toolbarbutton-icon {
  height: 16px;
  width: 16px;
}

The resulting WX icons size is 16 (16 px - 2x1 px padding = 14 px) instead of 18 px (18 px - 2x1 px padding = 16 px).

Comment 1

[Alex Ihrig [:Thunderbird_Mail_DE]]

Not sure about the right component. Maybe paenglab is the right person?

Comment 2

[Richard Marti (:Paenglab)]

Attachment: 1598955-WE-icon-dimension.patch

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2b3dd54098bf
Set the webextension icon to the same dimensions as the built-in icons. r=darktrojan

Comment 4

[Alex Ihrig [:Thunderbird_Mail_DE]]

The "funny" thing is: 2 days later my unchanged webextension button seems to use now the first CSS rule

.toolbarbutton-1 .toolbarbutton-icon {
  width: 18px;
  height: 18px;
}

instead of the prior used CSS rule:

.webextension-action > .toolbarbutton-badge-stack > .toolbarbutton-icon {
  height: 16px;
  width: 16px;
}

And the button size seems to be fixed without your patch (in my test profiles for Tb Daily and Tb Beta), which is in yesterdays comm-central build. In my test profile for Tb 68.2.2 the button icon is still to small and not fixed in a "magical" way.

Nevertheless, the patch seems to be correct and necessary to be checked-in for comm-beta and comm-esr.

Comment 5

[Geoff Lankow (:darktrojan)]

You are probably experiencing bug 1599275.

Comment 6

[Jorg K (CEST = GMT+2)]

Comment on attachment 9111370 [details] [diff] [review]
1598955-WE-icon-dimension.patch

Missed TB 71 beta 4 for some reason.

Comment 7

[Magnus Melin [:mkmelin]]

Comment on attachment 9111370 [details] [diff] [review]
1598955-WE-icon-dimension.patch

Yes we wanted to wait for the next beta. Let's keep the flags so it doesn't miss that.

Comment 8

[Magnus Melin [:mkmelin]]

Comment on attachment 9111370 [details] [diff] [review]
1598955-WE-icon-dimension.patch

Ah, then it's already there....

Comment 9

[Geoff Lankow (:darktrojan)]

68.3.1:
https://hg.mozilla.org/releases/comm-esr68/rev/390ae6612dee3d7366d7d5c2df90b3485714abb3