Bug 1610204 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

```
./mach static-analysis check --checks="-*, modernize-concat-nested-namespaces" --fix dom/media/webspeech/recognition/SpeechGrammar.cpp -j 30
```

while it has
```
namespace mozilla {
namespace dom {
```

Not that it seems to be an upstream issue:
```
run-clang-tidy-10 -fix -checks="-*, modernize-concat-nested-namespaces"  -extra-arg=-std=c++17 /home/sylvestre/dev/mozilla/autoland.hg/dom/media/webspeech/recognition/SpeechGrammar.cpp
Enabled checks:
    modernize-concat-nested-namespaces

clang-apply-replacements version 10.0.0
clang-tidy-10 -checks=-*, modernize-concat-nested-namespaces -export-fixes /tmp/tmpck2w2ds_/tmp5a7przqh.yaml -extra-arg=-std=c++17 -p=/home/sylvestre/dev/mozilla/autoland.hg /home/sylvestre/dev/mozilla/autoland.hg/dom/media/webspeech/recognition/SpeechGrammar.cpp
Applying fixes ...

```

And the file exists in the compile db:
```
 rg SpeechGrammar.cpp obj-x86_64-pc-linux-gnu/compile_commands.json
35010:"file": "/home/sylvestre/dev/mozilla/autoland.hg/dom/media/webspeech/recognition/SpeechGrammar.cpp"
```
```
./mach static-analysis check --checks="-*, modernize-concat-nested-namespaces" --fix dom/media/webspeech/recognition/SpeechGrammar.cpp -j 30
```

while it has
```
namespace mozilla {
namespace dom {
```

Note that it seems to be an upstream issue:
```
run-clang-tidy-10 -fix -checks="-*, modernize-concat-nested-namespaces"  -extra-arg=-std=c++17 /home/sylvestre/dev/mozilla/autoland.hg/dom/media/webspeech/recognition/SpeechGrammar.cpp
Enabled checks:
    modernize-concat-nested-namespaces

clang-apply-replacements version 10.0.0
clang-tidy-10 -checks=-*, modernize-concat-nested-namespaces -export-fixes /tmp/tmpck2w2ds_/tmp5a7przqh.yaml -extra-arg=-std=c++17 -p=/home/sylvestre/dev/mozilla/autoland.hg /home/sylvestre/dev/mozilla/autoland.hg/dom/media/webspeech/recognition/SpeechGrammar.cpp
Applying fixes ...

```

And the file exists in the compile db:
```
 rg SpeechGrammar.cpp obj-x86_64-pc-linux-gnu/compile_commands.json
35010:"file": "/home/sylvestre/dev/mozilla/autoland.hg/dom/media/webspeech/recognition/SpeechGrammar.cpp"
```

Back to Bug 1610204 Comment 0