1610204 - Running mach static-analysis isn't working on some files

Status: RESOLVED MOVED

(Developer Infrastructure :: Source Code Analysis, defect, P3)

Description

[Sylvestre Ledru [:Sylvestre]]

./mach static-analysis check --checks="-*, modernize-concat-nested-namespaces" --fix dom/media/webspeech/recognition/SpeechGrammar.cpp -j 30

while it has

namespace mozilla {
namespace dom {

Note that it seems to be an upstream issue:

run-clang-tidy-10 -fix -checks="-*, modernize-concat-nested-namespaces"  -extra-arg=-std=c++17 /home/sylvestre/dev/mozilla/autoland.hg/dom/media/webspeech/recognition/SpeechGrammar.cpp
Enabled checks:
    modernize-concat-nested-namespaces

clang-apply-replacements version 10.0.0
clang-tidy-10 -checks=-*, modernize-concat-nested-namespaces -export-fixes /tmp/tmpck2w2ds_/tmp5a7przqh.yaml -extra-arg=-std=c++17 -p=/home/sylvestre/dev/mozilla/autoland.hg /home/sylvestre/dev/mozilla/autoland.hg/dom/media/webspeech/recognition/SpeechGrammar.cpp
Applying fixes ...

And the file exists in the compile db:

 rg SpeechGrammar.cpp obj-x86_64-pc-linux-gnu/compile_commands.json
35010:"file": "/home/sylvestre/dev/mozilla/autoland.hg/dom/media/webspeech/recognition/SpeechGrammar.cpp"

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:Sylvestre, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Andi [:andi]]

After this lands to m-c we will no longer encounter this issue. Please also see this test run using the earlier mentioned patch.

Comment 3

[Sylvestre Ledru [:Sylvestre]]

This is caused by unified build and, we think that it impacts only one checker. Let's not worry too much about this!

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Closing as Andi and others have been working at fixing the non unified mode.
See bug 1626530