OK, I did investigate a bit, using devtools to see where things are & how big they are. What's happening here is roughly as follows: - We have the following markup: > <hbox id="downloads-animation-container"> > <vbox id="downloads-notification-anchor"> - The outer element (the hbox) has `height:1px`: https://searchfox.org/mozilla-central/rev/3811b11b5773c1dccfe8228bfc7143b10a9a2a99/browser/themes/shared/downloads/indicator.inc.css#158 - The inner element is the one whose styling was changed in bug 1410561 (replacing min/max-height with just `height`) - Due to XUL default min-size behavior (/me waves hands, I don't know XUL super well), the inner vbox allows itself to shrink as-needed (down to its parent's 1px size) by default, **unless** it has a specified `min-height` value. - So: for its `height:98px` to actually have an effect, it also needs `min-height:98px` (or else the 1px constraint from the parent "wins" and squashes it down).
Bug 1612104 Comment 17 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
OK, I did investigate a bit, using devtools to see where things are & how big they are. What's happening here is roughly as follows: - We have the following markup: > <hbox id="downloads-animation-container"> > <vbox id="downloads-notification-anchor"> - The outer element (the hbox) has `height:1px`: https://searchfox.org/mozilla-central/rev/3811b11b5773c1dccfe8228bfc7143b10a9a2a99/browser/themes/shared/downloads/indicator.inc.css#158 - The inner element is the one whose styling was changed in bug 1410561 (replacing `min-height` & `max-height` with just `height`) - Due to XUL default min-size behavior (/me waves hands, I don't know XUL super well), the inner vbox allows itself to shrink as-needed (down to its parent's 1px size) by default, **unless** it has a specified `min-height` value. - So: for its `height:98px` to actually have an effect, it also needs `min-height:98px` (or else the 1px constraint from the parent "wins" and squashes it down).
OK, I did investigate a bit, using devtools to see where things are & how big they are. What's happening here is roughly as follows: - We have the following markup: > <hbox id="downloads-animation-container"> > <vbox id="downloads-notification-anchor"> - The outer element (the hbox) has `height:1px`: https://searchfox.org/mozilla-central/rev/3811b11b5773c1dccfe8228bfc7143b10a9a2a99/browser/themes/shared/downloads/indicator.inc.css#158 - The inner element is the one whose styling was changed in bug 1410561 (replacing `min-height` & `max-height` with just `height`) - Due to XUL default min-size behavior (/me waves hands, I don't know XUL super well), the inner vbox allows itself to shrink as-needed (awayu from its specified 98px, all the way down to its parent's 1px size) by default, **unless** it has a specified `min-height` value. - So: for its `height:98px` to actually have an effect, it also needs `min-height:98px` (or else the 1px constraint from the parent "wins" and squashes it down). So, the animation isn't showing up because it's taking place in a 1px-tall box, rather than in a 98px-tall box.