Bug 1612245 Comment 3 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
(In reply to Magnus Melin [:mkmelin] from comment #2)
> Comment on attachment 9190136 [details] [diff] [review]
> 1612245-remove-nsIArray-from-nsIAutoSyncState-1.patch
> 
> Review of attachment 9190136 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: mailnews/imap/src/nsAutoSyncState.cpp
> @@ +669,3 @@
> >      while (x > toOffset && database) {
> >        x--;
> > +      if (q[x]) {
> 
> but there can be no null headers, right?

There certainly _shouldn't_ be, but a lot of code checks for it, so I'm not quite confident enough to remove these kinds of checks everywhere.
(The null checks we _can_ remove are ones checking for missing nsIArray objects. No longer a problem if we're passing around nsTArray<> references instead of nsIArray*)
Revision 1 by
on 
```
> ::: mailnews/imap/src/nsAutoSyncState.cpp
> @@ +669,3 @@
> >      while (x > toOffset && database) {
> >        x--;
> > +      if (q[x]) {
> 
> but there can be no null headers, right?
```
There certainly _shouldn't_ be, but a lot of code checks for it, so I'm not quite confident enough to remove these kinds of checks everywhere.
(The null checks we _can_ remove are ones checking for missing nsIArray objects. No longer a problem if we're passing around nsTArray<> references instead of nsIArray*)

Back to Bug 1612245 Comment 3