1612245 - Replace idl nsIArray usage with Array<T> in nsIAutoSyncState.idl

Status: RESOLVED FIXED

(MailNews Core :: General, task)

Description

[Ben Campbell]

mailnews/imap/public/nsIAutoSyncState.idl

Comment 1

[Ben Campbell]

Attachment: 1612245-remove-nsIArray-from-nsIAutoSyncState-1.patch

try run here:

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=c4822085b46ed8090a014bf04800a2ae5dc6f4b1

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9190136 [details] [diff] [review]
1612245-remove-nsIArray-from-nsIAutoSyncState-1.patch

Review of attachment 9190136 [details] [diff] [review]:
-----------------------------------------------------------------

::: mailnews/imap/src/nsAutoSyncState.cpp
@@ +669,3 @@
>      while (x > toOffset && database) {
>        x--;
> +      if (q[x]) {

but there can be no null headers, right?

Comment 3

[Ben Campbell]

> ::: mailnews/imap/src/nsAutoSyncState.cpp
> @@ +669,3 @@
> >      while (x > toOffset && database) {
> >        x--;
> > +      if (q[x]) {
> 
> but there can be no null headers, right?

There certainly shouldn't be, but a lot of code checks for it, so I'm not quite confident enough to remove these kinds of checks everywhere.
(The null checks we can remove are ones checking for missing nsIArray objects. No longer a problem if we're passing around nsTArray<> references instead of nsIArray*)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8cf7a7a83d99
Remove nsIArray usage from nsIAutoSyncState. r=mkmelin