Bug 1612338 Comment 3 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

LGTM.

> var tabPos = this.tabContainer.selectedIndex;
>       if (tabPos < this.browsers.length - 1) {

There are a bunch of small methods now only using the global "var tabPos" for one comparison. Should the comapre be done directly to avoid allocation of said global var? r/a+ either way. Can also be done in a follow-up if desired
LGTM.

> var tabPos = this.tabContainer.selectedIndex;
>       if (tabPos < this.browsers.length - 1) {

There are a bunch of small methods now only using the global "var tabPos" for one comparison. Should the compare be done directly to avoid allocation of said global var? r/a+ either way. Can also be done in a follow-up if desired

Back to Bug 1612338 Comment 3