1612338 - Switch moveTabTo method to using tab as first argument

Status: RESOLVED FIXED

(SeaMonkey :: Tabbed Browser, task)

Description

[Ian Neal]

Internally we use a mixture of tab and position when calling moveTabTo method, we should switch to using tab internally and assume that is the default but keep compatibility for extensions with still accepting a first argument of type number.

Comment 1

[Ian Neal]

Attachment: Make the switch

[Approval Request Comment]
Regression caused by (bug #): none
User impact if declined: none
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: none

Comment 2

[Ian Neal]

Attachment: Make the switch v1.1

Missed one change

Comment 3

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9123687 [details] [diff] [review]
Make the switch v1.1

LGTM.

> var tabPos = this.tabContainer.selectedIndex;
>       if (tabPos < this.browsers.length - 1) {

There are a bunch of small methods now only using the global "var tabPos" for one comparison. Should the compare be done directly to avoid allocation of said global var? r/a+ either way. Can also be done in a follow-up if desired

Comment 4

[Ian Neal]

Attachment: Make the switch v1.2

Suggested change made, carrying forward r/a+

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8c6e06c57b4e
Switch moveTabTo method to using tab as first argument. r=frg