There are certain a pieces of code that can be re-used in some captive portal tests[0]. For example - a) portalDetected[1] can be re-used in browser_captivePortalTabReference.js [2] b) openCaptivePortalErrorTab[3] can be moved to head.js and re-used in several captive portal tests c) openCaptivePortalLoginTab[4] can also be moved to head.js and re-used in several captive portal tests [0] https://searchfox.org/mozilla-central/source/browser/base/content/test/captivePortal [1] https://searchfox.org/mozilla-central/rev/8526066f548af9ec3ebb462ff73c47ccc183f533/browser/base/content/test/captivePortal/head.js#43 [2] https://searchfox.org/mozilla-central/rev/8526066f548af9ec3ebb462ff73c47ccc183f533/browser/base/content/test/captivePortal/browser_captivePortalTabReference.js#13 [3] https://searchfox.org/mozilla-central/rev/8526066f548af9ec3ebb462ff73c47ccc183f533/browser/base/content/test/captivePortal/browser_captivePortalTabReference.js#23 [4] https://searchfox.org/mozilla-central/rev/8526066f548af9ec3ebb462ff73c47ccc183f533/browser/base/content/test/captivePortal/browser_captivePortalTabReference.js#53
Bug 1625651 Comment 0 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
There are certain pieces of code that can be re-used in some captive portal tests[0]. For example - a) portalDetected[1] can be re-used in browser_captivePortalTabReference.js [2] b) openCaptivePortalErrorTab[3] can be moved to head.js and re-used in several captive portal tests c) openCaptivePortalLoginTab[4] can also be moved to head.js and re-used in several captive portal tests [0] https://searchfox.org/mozilla-central/source/browser/base/content/test/captivePortal [1] https://searchfox.org/mozilla-central/rev/8526066f548af9ec3ebb462ff73c47ccc183f533/browser/base/content/test/captivePortal/head.js#43 [2] https://searchfox.org/mozilla-central/rev/8526066f548af9ec3ebb462ff73c47ccc183f533/browser/base/content/test/captivePortal/browser_captivePortalTabReference.js#13 [3] https://searchfox.org/mozilla-central/rev/8526066f548af9ec3ebb462ff73c47ccc183f533/browser/base/content/test/captivePortal/browser_captivePortalTabReference.js#23 [4] https://searchfox.org/mozilla-central/rev/8526066f548af9ec3ebb462ff73c47ccc183f533/browser/base/content/test/captivePortal/browser_captivePortalTabReference.js#53