Closed Bug 1625651 Opened 1 year ago Closed 2 months ago

Clean up captive portal tests

Categories

(Firefox :: General, enhancement, P5)

enhancement

Tracking

()

RESOLVED FIXED
89 Branch
Tracking Status
firefox89 --- fixed

People

(Reporter: prathiksha, Assigned: claubatista, Mentored)

Details

Attachments

(4 files)

Priority: -- → P5

Can I work on this bug?

Flags: needinfo?(prathikshaprasadsuman)

(In reply to Amina Kenessova from comment #1)

Can I work on this bug?

Hi Amina, I'm sorry, I filed this bug for another contributor I am mentoring. I see you are currently working on a different patch that needs changes. LMK once you are done with that and I can find more bugs for you :)

Flags: needinfo?(prathikshaprasadsuman)
Assignee: nobody → aleja533
Status: NEW → ASSIGNED

aleja533, are you still working on this? Do you need any help?

Flags: needinfo?(aleja533)

Unassigning due to inactivity.

Assignee: aleja533 → skanthavar
Flags: needinfo?(aleja533)

Unassigning due to inactivity.

Assignee: skanthavar → nobody
Status: ASSIGNED → NEW
Assignee: nobody → skanthavar
Status: NEW → ASSIGNED

Sourab, are you still interested in finishing your patch? I have left some comments on how it can be improved before landing. No pressure if you're not. I just wanted to ask before forwarding it to another contributor. Thanks!

Flags: needinfo?(skanthavar)

Hi, I was going through the submitted patch - and I found a comment "Refactor browser_captivePortal_certErrorUI.js to also use these helper functions and variables introduced in head.js."
May You please elaborate it , I am not able to get it.

(In reply to bhurerenuka14 from comment #8)

Hi, I was going through the submitted patch - and I found a comment "Refactor browser_captivePortal_certErrorUI.js to also use these helper functions and variables introduced in head.js."
May You please elaborate it , I am not able to get it.

We can use the new helper functions and variables introduced in head.js in browser_captivePortal_certErrorUI.js.

hello, I have submitted D109740 with all changes, But then I realized that setCaptivePortalLoginState() wasn't removed.
Therefore I submitted another patch D109768 .

Attachment #9211523 - Attachment description: Bug 1625651 - Clean up captive portal tests final. r=prathiksha → Bug 1625651 - Clean up captive portal tests. r=prathiksha
Assignee: skanthavar → nobody
Status: ASSIGNED → NEW
Flags: needinfo?(skanthavar)
Assignee: nobody → bhurerenuka14
Status: NEW → ASSIGNED
Attachment #9211568 - Attachment description: Bug 1625651 - Clean up captive portal tests-removing setCaptivePortalLoginState. r=prathiksha → Bug 1625651 - Clean up captive portal tests. r=prathiksha

Assigning myself temporarily to prevent the Phabricator Automation bot from assigning it to folks submitting patches. This bug is open in general for all contributors I'm mentoring for Outreachy. Feel free to take a stab at it by submitting a patch.

Assignee: bhurerenuka14 → prathikshaprasadsuman
Pushed by prathikshaprasadsuman@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/d01fdaca3696
Clean up captive portal tests. r=prathiksha
Assignee: prathikshaprasadsuman → contatodaclau
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in before you can comment on or make changes to this bug.