Bug 1628727 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
Like `LoadImageWithChannel()`, the callers are
1. https://searchfox.org/mozilla-central/rev/4e228dc5f594340d35da7453829ad9f3c3cb8b58/dom/base/nsImageLoadingContent.cpp#973
2. https://searchfox.org/mozilla-central/rev/4e228dc5f594340d35da7453829ad9f3c3cb8b58/image/imgLoader.cpp#2368 where the `aCX` is from 
    -- https://searchfox.org/mozilla-central/rev/4e228dc5f594340d35da7453829ad9f3c3cb8b58/image/test/unit/async_load_tests.js#159
    -- https://searchfox.org/mozilla-central/rev/4e228dc5f594340d35da7453829ad9f3c3cb8b58/image/test/unit/async_load_tests.js#192
    -- https://searchfox.org/mozilla-central/rev/4e228dc5f594340d35da7453829ad9f3c3cb8b58/image/test/unit/async_load_tests.js#192
 
The nsISupports is from either Document or nullptr if I read code correctly. We could simplify them by using Document as type instead of cast Document to nsISupports and the queryInterface back to Document later.
Revision 1 by
on 
Like `LoadImageWithChannel()`, the callers are
1. https://searchfox.org/mozilla-central/rev/4e228dc5f594340d35da7453829ad9f3c3cb8b58/dom/base/nsImageLoadingContent.cpp#973
2. https://searchfox.org/mozilla-central/rev/4e228dc5f594340d35da7453829ad9f3c3cb8b58/image/imgLoader.cpp#2368 where the `aCX` is from 
    -- https://searchfox.org/mozilla-central/rev/4e228dc5f594340d35da7453829ad9f3c3cb8b58/image/test/unit/async_load_tests.js#159
    -- https://searchfox.org/mozilla-central/rev/4e228dc5f594340d35da7453829ad9f3c3cb8b58/image/test/unit/async_load_tests.js#192
    -- https://searchfox.org/mozilla-central/rev/4e228dc5f594340d35da7453829ad9f3c3cb8b58/image/test/unit/async_load_tests.js#192
 
The nsISupports is either Document or nullptr if I read code correctly. We could simplify them by using Document as type instead of cast Document to nsISupports and the queryInterface back to Document later.

Back to Bug 1628727 Comment 0