1628727 - Stop using nsISupports as argument type in some functions of ImageLoader

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, task, P3)

Description

[Edgar Chen [:edgar]]

Like LoadImageWithChannel(), the callers are

1. https://searchfox.org/mozilla-central/rev/4e228dc5f594340d35da7453829ad9f3c3cb8b58/dom/base/nsImageLoadingContent.cpp#973
2. https://searchfox.org/mozilla-central/rev/4e228dc5f594340d35da7453829ad9f3c3cb8b58/image/imgLoader.cpp#2368 where the aCX is from
   -- https://searchfox.org/mozilla-central/rev/4e228dc5f594340d35da7453829ad9f3c3cb8b58/image/test/unit/async_load_tests.js#159
   -- https://searchfox.org/mozilla-central/rev/4e228dc5f594340d35da7453829ad9f3c3cb8b58/image/test/unit/async_load_tests.js#192
   -- https://searchfox.org/mozilla-central/rev/4e228dc5f594340d35da7453829ad9f3c3cb8b58/image/test/unit/async_load_tests.js#192

The nsISupports is either Document or nullptr if I read code correctly. We could simplify them by using Document as type instead of cast Document to nsISupports and the queryInterface back to Document later.

Comment 1

[Edgar Chen [:edgar]]

Attachment: Bug 1628727 - Stop using nsISupports as argument type in some functions of imgLoader;

Comment 2

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=da30e8595bea30318a0d2825ebaf5bf591314858

Comment 3

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f989b6c160c6a6d196b673b05440a663934ae5e6&group_state=expanded

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/27d94573975d
Stop using nsISupports as argument type in some functions of imgLoader; r=tnikkel

Comment 5

[Noemi Erli[:noemi_erli]]

Backed out changeset 27d94573975d (Bug 1628727) for causing build bustages in imgRequest.cpp CLOSED TREE

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=297178634&resultStatus=testfailed%2Cbusted%2Cexception&revision=27d94573975d9f33c224241b48143a42cc4ffb73

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=297178634&repo=autoland&lineNumber=65014

Backout: https://hg.mozilla.org/integration/autoland/rev/023e79c6df52ea2693b5f6f35bdf504c88609881

Comment 6

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=221564bdddddf1c572e70761e1b35ba178ed82f5

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5261b2fbb4d4
Stop using nsISupports as argument type in some functions of imgLoader; r=tnikkel

Comment 8

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/5261b2fbb4d4