Bug 1642410 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by

Wolfgang Rosenauer [:wolfiR]

on 2020-06-01 11:06:54 PDT

When I try to build Firefox with PGO enabled, like:
ac_add_options MOZ_PGO=1
xvfb-run --server-args="-screen 0 1920x1080x24" \
./mach build -v
it fails with the following log:

[ 5171s] 85:23.37 gmake[1]: Leaving directory '/home/abuild/rpmbuild/BUILD/obj/instrumented/browser/installer'
[ 5171s] 85:23.37 gmake: Leaving directory '/home/abuild/rpmbuild/BUILD/obj/instrumented'
[ 5178s] ERROR:root:a bytes-like object is required, not 'str'
[ 5179s] Exception in thread ProcessReader:
[ 5179s] Traceback (most recent call last):
[ 5179s]   File "/usr/lib64/python3.8/threading.py", line 932, in _bootstrap_inner
[ 5179s]     self.run()
[ 5179s]   File "/usr/lib64/python3.8/threading.py", line 870, in run
[ 5179s]     self._target(*self._args, **self._kwargs)
[ 5179s]   File "/home/abuild/rpmbuild/BUILD/firefox-77.0/testing/mozbase/mozprocess/mozprocess/processhandler.py", line 1116, in _read
[ 5179s]     callback(line.rstrip())
[ 5179s]   File "/home/abuild/rpmbuild/BUILD/firefox-77.0/testing/mozbase/mozprocess/mozprocess/processhandler.py", line 1026, in __call__
[ 5179s]     e(*args, **kwargs)
[ 5179s]   File "/home/abuild/rpmbuild/BUILD/firefox-77.0/testing/mozbase/mozprocess/mozprocess/processhandler.py", line 1168, in __call__
[ 5179s]     self.stream.write(ensure(line) + ensure('\n'))
[ 5179s] TypeError: write() argument must be str, not bytes
[ 5184s] ERROR:root:a bytes-like object is required, not 'str'
[ 5187s] Exception in thread ProcessReader:
[ 5187s] Traceback (most recent call last):
[ 5187s]   File "/usr/lib64/python3.8/threading.py", line 932, in _bootstrap_inner
[ 5187s]     self.run()
[ 5187s]   File "/usr/lib64/python3.8/threading.py", line 870, in run
[ 5187s]     self._target(*self._args, **self._kwargs)
[ 5187s]   File "/home/abuild/rpmbuild/BUILD/firefox-77.0/testing/mozbase/mozprocess/mozprocess/processhandler.py", line 1116, in _read
[ 5187s]     callback(line.rstrip())
[ 5187s]   File "/home/abuild/rpmbuild/BUILD/firefox-77.0/testing/mozbase/mozprocess/mozprocess/processhandler.py", line 1026, in __call__
[ 5187s]     e(*args, **kwargs)
[ 5187s]   File "/home/abuild/rpmbuild/BUILD/firefox-77.0/testing/mozbase/mozprocess/mozprocess/processhandler.py", line 1168, in __call__
[ 5187s]     self.stream.write(ensure(line) + ensure('\n'))
[ 5187s] TypeError: write() argument must be str, not bytes
[ 5573s] jarlog: /home/abuild/rpmbuild/BUILD/obj/jarlog/en-US.log
[ 5573s] Could not find profraw files in the current directory: /home/abuild/rpmbuild/BUILD/obj/instrumented
[ 5573s]  Config object not found by mach.
[ 5573s] Configure complete!
[ 5573s] Be sure to run |mach build| to pick up any changes
[ 5573s] To view resource usage of the build, run |mach resource-usage|.
[ 5573s] To take your build for a test drive, run: |mach run|
[ 5573s] For more information on what to do now, see https://developer.mozilla.org/docs/Developer_Guide/So_You_Just_Built_Firefox
[ 5573s] Error running mach:
[ 5573s] 
[ 5573s]     ['build', '-v']
[ 5573s] 
[ 5573s] The error occurred in code that was called by the mach command. This is either
[ 5573s] a bug in the called code itself or in the way that mach is calling it.
[ 5573s] You can invoke |./mach busted| to check if this issue is already on file. If it
[ 5573s] isn't, please use |./mach busted file| to report it. If |./mach busted| is
[ 5573s] misbehaving, you can also inspect the dependencies of bug 1543241.
[ 5573s] 
[ 5573s] If filing a bug, please include the full output of mach, including this error
[ 5573s] message.
[ 5573s] 
[ 5573s] The details of the failure are as follows:
[ 5573s] 
[ 5573s] subprocess.CalledProcessError: Command '['/home/abuild/rpmbuild/BUILD/obj/instrumented/_virtualenvs/init_py3/bin/python', '/home/abuild/rpmbuild/BUILD/firefox-77.0/build/pgo/profileserver.py']' returned non-zero exit status 1.
[ 5573s] 
[ 5573s]   File "/home/abuild/rpmbuild/BUILD/firefox-77.0/python/mozbuild/mozbuild/build_commands.py", line 123, in build
[ 5573s]     subprocess.check_call(pgo_cmd, cwd=instr.topobjdir,
[ 5573s]   File "/usr/lib64/python3.8/subprocess.py", line 364, in check_call
[ 5573s]     raise CalledProcessError(retcode, cmd)
[ 5573s] error: Bad exit status from /var/tmp/rpm-tmp.v9UBsm (%build)
[ 5573s]

Revision 1 by

Mitchell Hentges [:mhentges] 🦀

on 2020-12-01 12:14:07 PST

When I try to build Firefox with PGO enabled, like:
ac_add_options MOZ_PGO=1
xvfb-run --server-args="-screen 0 1920x1080x24" \
./mach build -v
it fails with the following log:

```
[ 5171s] 85:23.37 gmake[1]: Leaving directory '/home/abuild/rpmbuild/BUILD/obj/instrumented/browser/installer'
[ 5171s] 85:23.37 gmake: Leaving directory '/home/abuild/rpmbuild/BUILD/obj/instrumented'
[ 5178s] ERROR:root:a bytes-like object is required, not 'str'
[ 5179s] Exception in thread ProcessReader:
[ 5179s] Traceback (most recent call last):
[ 5179s]   File "/usr/lib64/python3.8/threading.py", line 932, in _bootstrap_inner
[ 5179s]     self.run()
[ 5179s]   File "/usr/lib64/python3.8/threading.py", line 870, in run
[ 5179s]     self._target(*self._args, **self._kwargs)
[ 5179s]   File "/home/abuild/rpmbuild/BUILD/firefox-77.0/testing/mozbase/mozprocess/mozprocess/processhandler.py", line 1116, in _read
[ 5179s]     callback(line.rstrip())
[ 5179s]   File "/home/abuild/rpmbuild/BUILD/firefox-77.0/testing/mozbase/mozprocess/mozprocess/processhandler.py", line 1026, in __call__
[ 5179s]     e(*args, **kwargs)
[ 5179s]   File "/home/abuild/rpmbuild/BUILD/firefox-77.0/testing/mozbase/mozprocess/mozprocess/processhandler.py", line 1168, in __call__
[ 5179s]     self.stream.write(ensure(line) + ensure('\n'))
[ 5179s] TypeError: write() argument must be str, not bytes
[ 5184s] ERROR:root:a bytes-like object is required, not 'str'
[ 5187s] Exception in thread ProcessReader:
[ 5187s] Traceback (most recent call last):
[ 5187s]   File "/usr/lib64/python3.8/threading.py", line 932, in _bootstrap_inner
[ 5187s]     self.run()
[ 5187s]   File "/usr/lib64/python3.8/threading.py", line 870, in run
[ 5187s]     self._target(*self._args, **self._kwargs)
[ 5187s]   File "/home/abuild/rpmbuild/BUILD/firefox-77.0/testing/mozbase/mozprocess/mozprocess/processhandler.py", line 1116, in _read
[ 5187s]     callback(line.rstrip())
[ 5187s]   File "/home/abuild/rpmbuild/BUILD/firefox-77.0/testing/mozbase/mozprocess/mozprocess/processhandler.py", line 1026, in __call__
[ 5187s]     e(*args, **kwargs)
[ 5187s]   File "/home/abuild/rpmbuild/BUILD/firefox-77.0/testing/mozbase/mozprocess/mozprocess/processhandler.py", line 1168, in __call__
[ 5187s]     self.stream.write(ensure(line) + ensure('\n'))
[ 5187s] TypeError: write() argument must be str, not bytes
[ 5573s] jarlog: /home/abuild/rpmbuild/BUILD/obj/jarlog/en-US.log
[ 5573s] Could not find profraw files in the current directory: /home/abuild/rpmbuild/BUILD/obj/instrumented
[ 5573s]  Config object not found by mach.
[ 5573s] Configure complete!
[ 5573s] Be sure to run |mach build| to pick up any changes
[ 5573s] To view resource usage of the build, run |mach resource-usage|.
[ 5573s] To take your build for a test drive, run: |mach run|
[ 5573s] For more information on what to do now, see https://developer.mozilla.org/docs/Developer_Guide/So_You_Just_Built_Firefox
[ 5573s] Error running mach:
[ 5573s] 
[ 5573s]     ['build', '-v']
[ 5573s] 
[ 5573s] The error occurred in code that was called by the mach command. This is either
[ 5573s] a bug in the called code itself or in the way that mach is calling it.
[ 5573s] You can invoke |./mach busted| to check if this issue is already on file. If it
[ 5573s] isn't, please use |./mach busted file| to report it. If |./mach busted| is
[ 5573s] misbehaving, you can also inspect the dependencies of bug 1543241.
[ 5573s] 
[ 5573s] If filing a bug, please include the full output of mach, including this error
[ 5573s] message.
[ 5573s] 
[ 5573s] The details of the failure are as follows:
[ 5573s] 
[ 5573s] subprocess.CalledProcessError: Command '['/home/abuild/rpmbuild/BUILD/obj/instrumented/_virtualenvs/init_py3/bin/python', '/home/abuild/rpmbuild/BUILD/firefox-77.0/build/pgo/profileserver.py']' returned non-zero exit status 1.
[ 5573s] 
[ 5573s]   File "/home/abuild/rpmbuild/BUILD/firefox-77.0/python/mozbuild/mozbuild/build_commands.py", line 123, in build
[ 5573s]     subprocess.check_call(pgo_cmd, cwd=instr.topobjdir,
[ 5573s]   File "/usr/lib64/python3.8/subprocess.py", line 364, in check_call
[ 5573s]     raise CalledProcessError(retcode, cmd)
[ 5573s] error: Bad exit status from /var/tmp/rpm-tmp.v9UBsm (%build)
[ 5573s]
```

Back to Bug 1642410 Comment 0