Bug 1646567 Comment 2 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Nika Layzell [:nika] (ni? for response) from comment #1)
> ... only checking the docshell if it's present.

If I understand correctly, this means we'd only be checking same origin docshells up the tree. So if we had the situation `a.com <- b.com <- a.com`, e.g.:
```html
<!-- http://a.com -->
<iframe src="b.com"></iframe>

<!-- http://b.com -->
<iframe src="http://a.com/frame.html"></iframe>
```

If `nsDocShell::HasUnloadedParent` is called on the `http://a.com/frame.html` docshell, we'd end up just skipping over `b.com` for the unloaded check. Is this okay because if it was unloaded `http://a.com/frame.html`'s parent `WindowContext` (`http://b.com`) wouldn't be the current `WindowContext` of the `BrowsingContext`? or is there some other reason we can skip the check for OOP docshells in the tree?
(In reply to Nika Layzell [:nika] (ni? for response) from comment #1)
> ... only checking the docshell if it's present.

If I understand correctly, this means we'd only be checking same origin docshells up the tree. So if we had the situation `a.com <- b.com <- a.com`, e.g.:
```html
<!-- http://a.com -->
<iframe src="b.com"></iframe>

<!-- http://b.com -->
<iframe src="http://a.com/frame.html"></iframe>
```

If `nsDocShell::HasUnloadedParent` is called on the `http://a.com/frame.html` docshell, we'd end up not checking if the docshell for `b.com` is unloaded. Is this okay because if it was unloaded `http://a.com/frame.html`'s parent `WindowContext` (`http://b.com`) wouldn't be the current `WindowContext` of the `BrowsingContext`, so that's how we're checking it? or is there some other reason we can skip the check for OOP docshells in the tree?

Back to Bug 1646567 Comment 2