Bug 1651312 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
Because of bug 1647187 we have a lot of broken data type checks in our remote protocol browser-chrome mochitests. Here is the list:

```
remote/test/browser/page/browser_navigate.js
  FAIL identical - Got 4, expected 4
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/page/browser_navigate.js:testBasicNavigation:30
remote/test/browser/runtime/browser_callFunctionOn.js
  FAIL The subtype is null for numbers - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_callFunctionOn.js:awaitPromiseResolve:121
  FAIL The subtype is null for numbers - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_callFunctionOn.js:awaitPromiseDelayedResolve:136
  FAIL The subtype is null for objects - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_callFunctionOn.js:objectId:321
  FAIL The subtype is null for numbers - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_callFunctionOn.js:objectId:332
  FAIL The subtype is null for objects - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_callFunctionOn.js:objectIdArgumentReference:348
  FAIL The subtype is null for objects - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_callFunctionOn.js:objectIdArgumentReference:377
remote/test/browser/runtime/browser_callFunctionOn_returnByValue.js
  FAIL The subtype is correct - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_callFunctionOn_returnByValue.js:returnAsObjectTypes:53
  FAIL The subtype is correct - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_callFunctionOn_returnByValue.js:returnAsObjectTypes:53
remote/test/browser/runtime/browser_evaluate.js
  FAIL The subtype is null for numbers - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_evaluate.js:awaitPromiseResolve:38
  FAIL The subtype is null for numbers - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_evaluate.js:awaitPromiseDelayedResolve:69
  FAIL The subtype is correct - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_evaluate.js:returnAsObjectTypes:234
  FAIL The subtype is correct - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_evaluate.js:returnAsObjectTypes:234
remote/test/browser/runtime/browser_getProperties.js
  FAIL JS Object have no subtype - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_getProperties.js:testGetOwnSimpleProperties:37
  FAIL JS Object have no subtype - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_getProperties.js:testGetCustomProperty:168
  FAIL JS Object have no subtype - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_getProperties.js:testGetPrototypeProperties:97
  FAIL JS Object have no subtype - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_getProperties.js:testGetGetterSetterProperties:124
  FAIL The subtype is null for numbers - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_getProperties.js:testGetGetterSetterProperties:159
remote/test/browser/runtime/browser_remoteObjects.js
  FAIL JS Object have no subtype - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_remoteObjects.js:testObjectRelease:34
```

For a correct check (at the moment) you will have to modify the following code to make use of `===` and `!==`:

https://searchfox.org/mozilla-central/rev/7ec7ee4a9bde171ba195ab46ed6077e4baaef34d/testing/mochitest/browser-test.js#1326-1342
Revision 1 by
on 
Because of bug 1647187 we have a lot of broken data type checks in our remote protocol browser-chrome mochitests. Here is the list:

```
remote/test/browser/runtime/browser_callFunctionOn.js
  FAIL The subtype is null for numbers - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_callFunctionOn.js:awaitPromiseResolve:121
  FAIL The subtype is null for numbers - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_callFunctionOn.js:awaitPromiseDelayedResolve:136
  FAIL The subtype is null for objects - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_callFunctionOn.js:objectId:321
  FAIL The subtype is null for numbers - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_callFunctionOn.js:objectId:332
  FAIL The subtype is null for objects - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_callFunctionOn.js:objectIdArgumentReference:348
  FAIL The subtype is null for objects - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_callFunctionOn.js:objectIdArgumentReference:377
remote/test/browser/runtime/browser_callFunctionOn_returnByValue.js
  FAIL The subtype is correct - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_callFunctionOn_returnByValue.js:returnAsObjectTypes:53
  FAIL The subtype is correct - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_callFunctionOn_returnByValue.js:returnAsObjectTypes:53
remote/test/browser/runtime/browser_evaluate.js
  FAIL The subtype is null for numbers - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_evaluate.js:awaitPromiseResolve:38
  FAIL The subtype is null for numbers - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_evaluate.js:awaitPromiseDelayedResolve:69
  FAIL The subtype is correct - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_evaluate.js:returnAsObjectTypes:234
  FAIL The subtype is correct - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_evaluate.js:returnAsObjectTypes:234
remote/test/browser/runtime/browser_getProperties.js
  FAIL JS Object have no subtype - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_getProperties.js:testGetOwnSimpleProperties:37
  FAIL JS Object have no subtype - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_getProperties.js:testGetCustomProperty:168
  FAIL JS Object have no subtype - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_getProperties.js:testGetPrototypeProperties:97
  FAIL JS Object have no subtype - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_getProperties.js:testGetGetterSetterProperties:124
  FAIL The subtype is null for numbers - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_getProperties.js:testGetGetterSetterProperties:159
remote/test/browser/runtime/browser_remoteObjects.js
  FAIL JS Object have no subtype - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_remoteObjects.js:testObjectRelease:34
```

For a correct check (at the moment) you will have to modify the following code to make use of `===` and `!==`:

https://searchfox.org/mozilla-central/rev/7ec7ee4a9bde171ba195ab46ed6077e4baaef34d/testing/mochitest/browser-test.js#1326-1342
Revision 2 by
on 
Because of bug 1647187 we have a lot of broken data type checks in our remote protocol browser-chrome mochitests. Here is the list:

```
remote/test/browser/page/browser_navigate.js
  FAIL identical - Got 4, expected 4
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/page/browser_navigate.js:testBasicNavigation:30
remote/test/browser/runtime/browser_callFunctionOn.js
  FAIL The subtype is null for numbers - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_callFunctionOn.js:awaitPromiseResolve:121
  FAIL The subtype is null for numbers - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_callFunctionOn.js:awaitPromiseDelayedResolve:136
  FAIL The subtype is null for objects - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_callFunctionOn.js:objectId:321
  FAIL The subtype is null for numbers - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_callFunctionOn.js:objectId:332
  FAIL The subtype is null for objects - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_callFunctionOn.js:objectIdArgumentReference:348
  FAIL The subtype is null for objects - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_callFunctionOn.js:objectIdArgumentReference:377
remote/test/browser/runtime/browser_callFunctionOn_returnByValue.js
  FAIL The subtype is correct - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_callFunctionOn_returnByValue.js:returnAsObjectTypes:53
  FAIL The subtype is correct - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_callFunctionOn_returnByValue.js:returnAsObjectTypes:53
remote/test/browser/runtime/browser_evaluate.js
  FAIL The subtype is null for numbers - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_evaluate.js:awaitPromiseResolve:38
  FAIL The subtype is null for numbers - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_evaluate.js:awaitPromiseDelayedResolve:69
  FAIL The subtype is correct - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_evaluate.js:returnAsObjectTypes:234
  FAIL The subtype is correct - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_evaluate.js:returnAsObjectTypes:234
remote/test/browser/runtime/browser_getProperties.js
  FAIL JS Object have no subtype - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_getProperties.js:testGetOwnSimpleProperties:37
  FAIL JS Object have no subtype - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_getProperties.js:testGetCustomProperty:168
  FAIL JS Object have no subtype - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_getProperties.js:testGetPrototypeProperties:97
  FAIL JS Object have no subtype - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_getProperties.js:testGetGetterSetterProperties:124
  FAIL The subtype is null for numbers - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_getProperties.js:testGetGetterSetterProperties:159
remote/test/browser/runtime/browser_remoteObjects.js
  FAIL JS Object have no subtype - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_remoteObjects.js:testObjectRelease:34
```

For a correct check (at the moment) you will have to modify the following code to make use of `===` and `!==`:

https://searchfox.org/mozilla-central/rev/7ec7ee4a9bde171ba195ab46ed6077e4baaef34d/testing/mochitest/browser-test.js#1326-1342

Back to Bug 1651312 Comment 0