Review of attachment 9166510 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me. r=khushil324 I was seeing "JavaScript error: resource:///modules/AddrBookManager.jsm, line 204: InternalError: too much recursion" and now it's working. I had mentioned it previously in the last bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1653234#c25 but then I was not able to reproduce this again so missed it. Here, I am also facing: I am not able to open the contact dialog of the contacts from the macOS Addressbook Mailing list/Group. Seeing this error: ``JavaScript error: chrome://messenger/content/addressbook/abCommon.js, line 545: TypeError: can't access property "URI", directory is null``. What can we do about it? Otherwise, it looks good.
Bug 1655685 Comment 4 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Review of attachment 9166510 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me. r=khushil324 I was seeing "JavaScript error: resource:///modules/AddrBookManager.jsm, line 204: InternalError: too much recursion" and now it's working. I had mentioned it previously in the last bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1653234#c25 but then I was not able to reproduce this again so missed it. Here, I am also facing: I am not able to open the contact dialog of the contacts from the macOS Addressbook Mailing list/Group. Seeing this error: JavaScript error: chrome://messenger/content/addressbook/abCommon.js, line 545: TypeError: can't access property "URI", directory is null. What can we do about it? Otherwise, it looks good.
(Hidden by Administrator)
Review of attachment 9166510 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me. r=khushil324 I was seeing "JavaScript error: resource:///modules/AddrBookManager.jsm, line 204: InternalError: too much recursion" and now it's working. I had mentioned it previously in the last bug 1653234 comment 25 but then I was not able to reproduce this again so missed it. Here, I am also facing: I am not able to open the contact dialog of the contacts from the macOS Addressbook Mailing list/Group. Seeing this error: JavaScript error: chrome://messenger/content/addressbook/abCommon.js, line 545: TypeError: can't access property "URI", directory is null. What can we do about it? Otherwise, it looks good.