OS X address book initialisation broken. Launching/updating Thunderbird on Mac can hang.
Categories
(Thunderbird :: Address Book, defect)
Tracking
(thunderbird_esr78 fixed, thunderbird79 wontfix, thunderbird80 fixed, thunderbird81 fixed)
People
(Reporter: darktrojan, Assigned: darktrojan)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
1.38 KB,
patch
|
khushil324
:
review+
wsmwk
:
approval-comm-beta+
wsmwk
:
approval-comm-esr78+
|
Details | Diff | Splinter Review |
Bug 1653234 (quite reasonably) made a change to remember address books only after their successful initialisation. However this has broken the OS X address book provider where there are mailing lists in the OS contacts. This is because of the weird way that provider initialises mailing lists during the parent address book's initialisation.
Assignee | ||
Comment 1•4 years ago
|
||
Comment 2•4 years ago
|
||
We really want this for 78.1.0 - which we will do on Wednesday if it has been reviewed.
If khushil can't review it in the next 12 hours, it would be great if someone could steal the review.
Comment 3•4 years ago
|
||
Reviewing it right now.
Comment 4•4 years ago
•
|
||
Comment on attachment 9166510 [details] [diff] [review] 1655685-osx-ab-init-1.diff Review of attachment 9166510 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me. r=khushil324 I was seeing "JavaScript error: resource:///modules/AddrBookManager.jsm, line 204: InternalError: too much recursion" and now it's working. I had mentioned it previously in the last bug 1653234 comment 25 but then I was not able to reproduce this again so missed it. Here, I am also facing: I am not able to open the contact dialog of the contacts from the macOS Addressbook Mailing list/Group. Seeing this error: JavaScript error: chrome://messenger/content/addressbook/abCommon.js, line 545: TypeError: can't access property "URI", directory is null. What can we do about it? Otherwise, it looks good.
Assignee | ||
Comment 5•4 years ago
|
||
Here, I am also facing: I am not able to open the contact dialog of the
contacts from the macOS Addressbook Mailing list/Group. Seeing this error:
JavaScript error: chrome://messenger/content/addressbook/abCommon.js, line
545: TypeError: can't access property "URI", directory is null. What can we
do about it?
I think that was a pre-existing problem. AFAICT it happens only when a mailing list is open and you try to edit one of the contacts. The mailing list UUID property is wrong. It's not worth stopping this patch for, so I'll look at it in a follow-up bug.
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/88df419ba851
Fix initialisation of OSX address book. r=khushil
Assignee | ||
Updated•4 years ago
|
Comment 7•4 years ago
|
||
Comment on attachment 9166510 [details] [diff] [review] 1655685-osx-ab-init-1.diff Approved for beta. Approved for esr78.
Comment 8•4 years ago
|
||
Comment 9•4 years ago
|
||
Comment 10•4 years ago
|
||
Eckard, is this the issue you were seeing, and can you confirm the hang is gone?
Comment 11•4 years ago
|
||
It's the issue I have been seeing repeatedly when I created a new profile: TB hanging and memory usage rising to peaks of >8 GB, TB finally no longer responding. TB never opened the main window.
This issue is gone in TB 78.1.0-candidates/build2/ which I tested yesterday!
Description
•