Bug 1658968 Comment 3 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Asif Youssuff from comment #2)
> Harry, the issue here is that the option is now inconsistent with the new design.

We overwrote the `browser.urlbar.suggest.searches` pref (the one that shows suggestions in the Urlbar) before, like in the `@google apple` example in comment 1. That pref only acts on searches that don't use an alias or restriction token. Is there something more inconsistent about the pref now?

> Perhaps it makes sense to revert to the previous functionality of doing the search immediately if search suggestions are disabled?

I can run it by UX, but part of the motivation behind this change is to simplify aliases, one-offs, and keywords. User research showed us that most users don't understand these features and don't know that you can search with an engine other than your default. I think we want to avoid too much branching logic and special cases.
(In reply to Asif Youssuff from comment #2)
> Harry, the issue here is that the option is now inconsistent with the new design.

We overwrote the `browser.urlbar.suggest.searches` pref (the one that shows suggestions in the Urlbar) before, like in the `@google apple` example in comment 1. That pref only acts on searches that don't use an alias or restriction token. Is there something more inconsistent about the pref now?

> Perhaps it makes sense to revert to the previous functionality of doing the search immediately if search suggestions are disabled?

I can run it by UX, but part of the motivation behind this change is to simplify aliases, one-offs, and keywords. User research showed us that many users don't understand these features and don't know that you can search with an engine other than your default. I think we want to avoid too much branching logic and special cases.

Back to Bug 1658968 Comment 3