Selecting search engine from scope ignores "Show search suggestions in address bar results" preference
Categories
(Firefox :: Address Bar, defect, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox81 | --- | affected |
People
(Reporter: yoasif, Unassigned)
References
Details
(Keywords: blocked-ux, nightly-community)
Steps to reproduce:
- disable "Show search suggestions in address bar results" preference
- type "apple" into address bar
- click search engines in search scope bar
What happens:
search suggestions appear
Expected result:
search suggestions do not appear
|
Reporter | |
Updated•4 years ago
|
|
||
Comment 1•4 years ago
•
|
||
I'll have to confirm with UX, but this is expected. The feature you're filing against is the new "search mode". It is intended to unify the separate behaviour of one-offs, custom engine aliases, @ aliases, and (eventually) bookmark keywords. The user has explicitly said they want to do a search with a particular engine, so we always show suggestions. Similar to how we showed suggestions for @google apple before this feature was turned on.
EDIT: We showed suggestions for @google apple regardless of whether the user had suggestions in the Urlbar turned on.
|
||
Updated•4 years ago
|
|
|
Reporter | |
Comment 2•4 years ago
•
|
||
Harry, the issue here is that the option is now inconsistent with the new design. Perhaps it makes sense to revert to the previous functionality of doing the search immediately if search suggestions are disabled?
The new design is causing some confusion in that regard, see: https://www.reddit.com/r/firefox/comments/i8zjf8/now_searching_in_a_nondefault_search_engine/
|
|
||
Comment 3•4 years ago
•
|
||
(In reply to Asif Youssuff from comment #2)
Harry, the issue here is that the option is now inconsistent with the new design.
We overwrote the browser.urlbar.suggest.searches pref (the one that shows suggestions in the Urlbar) before, like in the @google apple example in comment 1. That pref only acts on searches that don't use an alias or restriction token. Is there something more inconsistent about the pref now?
Perhaps it makes sense to revert to the previous functionality of doing the search immediately if search suggestions are disabled?
I can run it by UX, but part of the motivation behind this change is to simplify aliases, one-offs, and keywords. User research showed us that many users don't understand these features and don't know that you can search with an engine other than your default. I think we want to avoid too much branching logic and special cases.
|
|
||
Comment 4•4 years ago
|
||
We got clarification from UX, and Harry is correct in comment 1: Just as we show suggestions when you type @google apple even when you've disabled them in about:preferences, we should show suggestions in search mode. Additionally, UX says we should also probably rename/reorganize those preferences so this is clearer, but they're still thinking on that, and it's another bug anyway, so I'll close this one.
Description
•