Bug 1674734 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

A-C is upgrading AndroidX dependencies in https://github.com/mozilla-mobile/android-components/pull

This triggers some deprecation warnings:

```
[task 2020-10-29T11:15:52.817Z] w: /builds/worker/checkouts/src/samples/glean/src/androidTest/java/org/mozilla/samples/glean/MainActivityTest.kt: (11, 27): 'ActivityTestRule<T : Activity!>' is deprecated. Deprecated in Java
[task 2020-10-29T11:15:52.817Z] w: /builds/worker/checkouts/src/samples/glean/src/androidTest/java/org/mozilla/samples/glean/MainActivityTest.kt: (23, 23): 'ActivityTestRule<T : Activity!>' is deprecated. Deprecated in Java
[task 2020-10-29T11:15:52.817Z] w: /builds/worker/checkouts/src/samples/glean/src/androidTest/java/org/mozilla/samples/glean/MainActivityTest.kt: (23, 56): 'ActivityTestRule<T : Activity!>' is deprecated. Deprecated in Java
[task 2020-10-29T11:15:52.817Z] w: /builds/worker/checkouts/src/samples/glean/src/androidTest/java/org/mozilla/samples/glean/pings/BaselinePingTest.kt: (11, 27): 'ActivityTestRule<T : Activity!>' is deprecated. Deprecated in Java
[task 2020-10-29T11:15:52.817Z] w: /builds/worker/checkouts/src/samples/glean/src/androidTest/java/org/mozilla/samples/glean/pings/BaselinePingTest.kt: (62, 23): 'ActivityTestRule<T : Activity!>' is deprecated. Deprecated in Java
[task 2020-10-29T11:15:52.817Z] w: /builds/worker/checkouts/src/samples/glean/src/androidTest/java/org/mozilla/samples/glean/pings/BaselinePingTest.kt: (62, 56): 'ActivityTestRule<T : Activity!>' is deprecated. Deprecated in Java
```

It's rather easy to resolve:

```diff
-    val activityRule: ActivityTestRule<MainActivity> = ActivityTestRule(MainActivity::class.java)
+    val activityRule: ActivityScenarioRule<MainActivity> = ActivityScenarioRule(MainActivity::class.java)
```

We should probably apply the same to the Glean SDK.
A-C is upgrading AndroidX dependencies in https://github.com/mozilla-mobile/android-components/pull/8839

This triggers some deprecation warnings:

```
[task 2020-10-29T11:15:52.817Z] w: /builds/worker/checkouts/src/samples/glean/src/androidTest/java/org/mozilla/samples/glean/MainActivityTest.kt: (11, 27): 'ActivityTestRule<T : Activity!>' is deprecated. Deprecated in Java
[task 2020-10-29T11:15:52.817Z] w: /builds/worker/checkouts/src/samples/glean/src/androidTest/java/org/mozilla/samples/glean/MainActivityTest.kt: (23, 23): 'ActivityTestRule<T : Activity!>' is deprecated. Deprecated in Java
[task 2020-10-29T11:15:52.817Z] w: /builds/worker/checkouts/src/samples/glean/src/androidTest/java/org/mozilla/samples/glean/MainActivityTest.kt: (23, 56): 'ActivityTestRule<T : Activity!>' is deprecated. Deprecated in Java
[task 2020-10-29T11:15:52.817Z] w: /builds/worker/checkouts/src/samples/glean/src/androidTest/java/org/mozilla/samples/glean/pings/BaselinePingTest.kt: (11, 27): 'ActivityTestRule<T : Activity!>' is deprecated. Deprecated in Java
[task 2020-10-29T11:15:52.817Z] w: /builds/worker/checkouts/src/samples/glean/src/androidTest/java/org/mozilla/samples/glean/pings/BaselinePingTest.kt: (62, 23): 'ActivityTestRule<T : Activity!>' is deprecated. Deprecated in Java
[task 2020-10-29T11:15:52.817Z] w: /builds/worker/checkouts/src/samples/glean/src/androidTest/java/org/mozilla/samples/glean/pings/BaselinePingTest.kt: (62, 56): 'ActivityTestRule<T : Activity!>' is deprecated. Deprecated in Java
```

It's rather easy to resolve:

```diff
-    val activityRule: ActivityTestRule<MainActivity> = ActivityTestRule(MainActivity::class.java)
+    val activityRule: ActivityScenarioRule<MainActivity> = ActivityScenarioRule(MainActivity::class.java)
```

We should probably apply the same to the Glean SDK.

Back to Bug 1674734 Comment 0