(In reply to Tyson Smith [:tsmith] from comment #0) > I think bug 1685439 should have been caught by ASan but was not. > > I don't think sainitizer build flags are being passed properly but someone that knows this code better would know for sure. > > https://searchfox.org/mozilla-central/rev/ef900cd2258d4c5d968093f612f807d96e6e7c98/gfx/wr/swgl/build.rs#137 I would appreciate if this was not marked as a sec issue and refiled as just a normal build issue against SWGL since this doesn't really represent a sec issue as such.
Bug 1685446 Comment 1 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
(In reply to Tyson Smith [:tsmith] from comment #0) > I think bug 1685439 should have been caught by ASan but was not. > > I don't think sainitizer build flags are being passed properly but someone that knows this code better would know for sure. > > https://searchfox.org/mozilla-central/rev/ef900cd2258d4c5d968093f612f807d96e6e7c98/gfx/wr/swgl/build.rs#137 I would appreciate if this was not marked as a sec issue and refiled as just a normal build issue against SWGL since this doesn't really represent a sec issue as such. It's just a TODO item since gl.cc is built separately on purpose using the rust CC crate.
(In reply to Tyson Smith [:tsmith] from comment #0) > I think bug 1685439 should have been caught by ASan but was not. > > I don't think sainitizer build flags are being passed properly but someone that knows this code better would know for sure. > > https://searchfox.org/mozilla-central/rev/ef900cd2258d4c5d968093f612f807d96e6e7c98/gfx/wr/swgl/build.rs#137 I would appreciate if this was not marked as a sec issue and refiled as just a normal build issue against SWGL since this doesn't really represent a sec issue as such. It would be far easier for me to get the eyeballs on it I need that way. It's just a TODO item since gl.cc is built separately on purpose using the rust CC crate.
(In reply to Tyson Smith [:tsmith] from comment #0) > I think bug 1685439 should have been caught by ASan but was not. > > I don't think sainitizer build flags are being passed properly but someone that knows this code better would know for sure. > > https://searchfox.org/mozilla-central/rev/ef900cd2258d4c5d968093f612f807d96e6e7c98/gfx/wr/swgl/build.rs#137 I would appreciate if this was not marked as a sec issue and refiled as just a normal build issue against SWGL, since this doesn't really represent a sec issue as such. It would be easier to get more eyeballs on it that way. It's just a TODO item since gl.cc is built separately on purpose using the rust CC crate.