1685446 - gl.cc not built with ASan

Status: NEW

(Core :: Graphics: WebRender, enhancement, P4)

Description

[Tyson Smith [:tsmith]]

I think bug 1685439 should have been caught by ASan but was not.

I don't think sainitizer build flags are being passed properly but someone that knows this code better would know for sure.

https://searchfox.org/mozilla-central/rev/ef900cd2258d4c5d968093f612f807d96e6e7c98/gfx/wr/swgl/build.rs#137

Comment 1

[Lee Salzman [:lsalzman]]

(In reply to Tyson Smith [:tsmith] from comment #0)

I think bug 1685439 should have been caught by ASan but was not.

I don't think sainitizer build flags are being passed properly but someone that knows this code better would know for sure.

https://searchfox.org/mozilla-central/rev/ef900cd2258d4c5d968093f612f807d96e6e7c98/gfx/wr/swgl/build.rs#137

I would appreciate if this was not marked as a sec issue and refiled as just a normal build issue against SWGL, since this doesn't really represent a sec issue as such. It would be easier to get more eyeballs on it that way. It's just a TODO item since gl.cc is built separately on purpose using the rust CC crate.

Comment 2

[Mike Hommey [:glandium]]

See https://searchfox.org/mozilla-central/rev/014fe72eaba26dcf6082fb9bbaf208f97a38594e/config/makefiles/rust.mk#158-165

Comment 3

[Lee Salzman [:lsalzman]]

(In reply to Mike Hommey [:glandium] from comment #2)

See https://searchfox.org/mozilla-central/rev/014fe72eaba26dcf6082fb9bbaf208f97a38594e/config/makefiles/rust.mk#158-165

Just thinking out loud, is there some way we could detect in the build.rs for SWGL that we are trying to do an ASAN build, and just have the build.rs manually chuck on the flag in this case as-needed?

Comment 4

[Mike Hommey [:glandium]]

Note that sanitizer flags are passed down when cross-compiling, so that code should be covered on Windows, Mac and Android asan builds.

Comment 5

[Brad Werth [:bradwerth] | Out until July 3]

Changing severity to S4 because of its nature as an ehancement.