Bug 1689648 Comment 1 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
We won't need this for at least six months but the patch is:

diff --git a/tools/clang-tidy/test/bugprone-assert-side-effect.json b/tools/clang-tidy/test/bugprone-assert-side-effect.json
--- a/tools/clang-tidy/test/bugprone-assert-side-effect.json
+++ b/tools/clang-tidy/test/bugprone-assert-side-effect.json
@@ -1,1 +1,1 @@
-[["warning", "found assert() with side effect", "bugprone-assert-side-effect"], {"reliability": "high"}]
\ No newline at end of file
+[["warning", "side effect in assert() condition discarded in release builds", "bugprone-assert-side-effect"], {"reliability": "high"}]
Revision 1 by
on 
We won't need this for at least six months but the patch is:

```diff
diff --git a/tools/clang-tidy/test/bugprone-assert-side-effect.json b/tools/clang-tidy/test/bugprone-assert-side-effect.json
--- a/tools/clang-tidy/test/bugprone-assert-side-effect.json
+++ b/tools/clang-tidy/test/bugprone-assert-side-effect.json
@@ -1,1 +1,1 @@
-[["warning", "found assert() with side effect", "bugprone-assert-side-effect"], {"reliability": "high"}]
\ No newline at end of file
+[["warning", "side effect in assert() condition discarded in release builds", "bugprone-assert-side-effect"], {"reliability": "high"}]
```

Back to Bug 1689648 Comment 1