Here's a list of the code I've been able to find in the Mozilla tree which does macOS version checking: 1) All code changed by the patch for bug 1616404: https://hg.mozilla.org/mozilla-central/rev/37c75bf1c2b2 2) Gfx version checking code: https://hg.mozilla.org/mozilla-central/annotate/147065aaa29152bf01bd0a6d1e5eb7089ff069e3/widget/cocoa/GfxInfo.mm#l37 3) Sandbox version checking code: https://hg.mozilla.org/mozilla-central/annotate/147065aaa29152bf01bd0a6d1e5eb7089ff069e3/security/sandbox/mac/Sandbox.mm#l106 Like I said in comment 4, it doesn't seem that any of it needs to be changed to accommodate my patch.
Bug 1690604 Comment 5 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Here's a list of the code I've been able to find in the Mozilla tree which does macOS version checking: 1) All code changed by the patch for bug 1616404: https://hg.mozilla.org/mozilla-central/rev/37c75bf1c2b2 2) Gfx version checking code: https://hg.mozilla.org/mozilla-central/annotate/147065aaa29152bf01bd0a6d1e5eb7089ff069e3/widget/cocoa/GfxInfo.mm#l37 3) Sandbox version checking code: https://hg.mozilla.org/mozilla-central/annotate/147065aaa29152bf01bd0a6d1e5eb7089ff069e3/security/sandbox/mac/Sandbox.mm#l106 4) https://hg.mozilla.org/mozilla-central/annotate/147065aaa29152bf01bd0a6d1e5eb7089ff069e3/dom/media/platforms/apple/AppleDecoderModule.cpp#l157 Like I said in comment 4, it doesn't seem that any of it needs to be changed to accommodate my patch. `__builtin_available()` is a new Clang feature, and seems to be smart enough to work with either "macos 10.16" or "macos 11". I double-checked this by building the tree (with the macOS 11 SDK) on an Apple Silicon Mac Mini. I found items 2 through 4 by searching on "10.16" in https://searchfox.org/ :-)
Here's a list of the code I've been able to find in the Mozilla tree which does macOS version checking: 1) All code changed by the patch for bug 1616404: https://hg.mozilla.org/mozilla-central/rev/37c75bf1c2b2 2) Gfx version checking code: https://hg.mozilla.org/mozilla-central/annotate/147065aaa29152bf01bd0a6d1e5eb7089ff069e3/widget/cocoa/GfxInfo.mm#l37 3) Sandbox version checking code: https://hg.mozilla.org/mozilla-central/annotate/147065aaa29152bf01bd0a6d1e5eb7089ff069e3/security/sandbox/mac/Sandbox.mm#l106 4) https://hg.mozilla.org/mozilla-central/annotate/147065aaa29152bf01bd0a6d1e5eb7089ff069e3/dom/media/platforms/apple/AppleDecoderModule.cpp#l157 Like I said in comment 4, it doesn't seem that any of it needs to be changed to accommodate my patch. `__builtin_available()` is a new Clang feature, and seems to be smart enough to work with either "macos 10.16" or "macos 11". I double-checked this by building the tree with my patch (with the macOS 11 SDK) on an Apple Silicon Mac Mini. I found items 2 through 4 by searching on "10.16" in https://searchfox.org/ :-)