1616404 - Fix version detection for macOS 10.16

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect, P2)

Description

[Philipp Kewisch [:Fallen][📱📆]]

The version detection at https://searchfox.org/mozilla-central/source/widget/cocoa/nsCocoaFeatures.mm works for versions up to 10.15. As this is the current macOS version it would be good to fix this code to support greater versions before Apple decides to seed a new version of macOS.

Comment 1

[Stephen A Pohl [:spohl] (OOO until 2/27)]

This will need a fix to accommodate major versions greater than 10, minor versions greater than 15, or (less likely) both. Not sure if there is any indication yet if the next version is going to have a major version of 11, or a minor version of 16.

Comment 2

[Stephen A Pohl [:spohl] (OOO until 2/27)]

Attachment: Bug 1616404: Change macOS version detection to accommodate major versions between 10 and 255 as well as minor and bugfix versions between 0 and 255. r=mstange

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/06fadee788b3
Change macOS version detection to accommodate major versions between 10 and 255 as well as minor and bugfix versions between 0 and 255. r=mstange

Comment 4

[Dorel Luca [:dluca]]

Backed out changeset 06fadee788b3 (bug 1616404) for XPCShell failures on OSX in xpcshell/rs-blocklist/test_gfxBlacklist_OK.js. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=300714398&repo=autoland&lineNumber=4277

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=06fadee788b3781c5d46dee1e02a9e9378127515

Backout:
https://hg.mozilla.org/integration/autoland/rev/e62bc734f0d79a676695596c012aaa367afeabd4

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/37c75bf1c2b2
Change macOS version detection to accommodate major versions between 10 and 255 as well as minor and bugfix versions between 0 and 255. r=mstange

Comment 6

[Stephen A Pohl [:spohl] (OOO until 2/27)]

Fixed tests.

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/37c75bf1c2b2