Bug 1692324 Comment 6 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
### Beta/Release Uplift Approval Request
* **User impact if declined**: Impact to a stud we wanted to run. I'm aware this is an uplift in RC, and not totally sure if that's reasonable or not, but I think with how small of a change this is, it felt like worth a try given the impact of the experiment.
* **Is this code covered by automated tests?**: Yes
* **Has the fix been verified in Nightly?**: No
* **Needs manual test from QE?**: Yes
* **If yes, steps to reproduce**: 1. Set extensions.pocket.loggedOutVariant to "button_variant"
2. be logged out of Pocket
3. Try to save a link
4. In the doorhanger log in prompt, click the "sign up" button

Expected: It should take you to a page with multiple sign up options.
* **List of other uplifts needed**: None
* **Risk to taking this patch**: Low
* **Why is the change risky/not risky? (and alternatives if risky)**: It's a 1 line fix to update a url param that's behind a pref, so should be really low risk.
* **String changes made/needed**: None
Revision 1 by
on 
### Beta/Release Uplift Approval Request
* **User impact if declined**: Impact to a study we wanted to run. I'm aware this is an uplift in RC, and not totally sure if that's reasonable or not, but I think with how small of a change this is, it felt like worth a try given the impact of the experiment.
* **Is this code covered by automated tests?**: Yes
* **Has the fix been verified in Nightly?**: No
* **Needs manual test from QE?**: Yes
* **If yes, steps to reproduce**: 1. Set extensions.pocket.loggedOutVariant to "button_variant"
2. be logged out of Pocket
3. Try to save a link
4. In the doorhanger log in prompt, click the "sign up" button

Expected: It should take you to a page with multiple sign up options.
* **List of other uplifts needed**: None
* **Risk to taking this patch**: Low
* **Why is the change risky/not risky? (and alternatives if risky)**: It's a 1 line fix to update a url param that's behind a pref, so should be really low risk.
* **String changes made/needed**: None
Revision 2 by
on 
### Beta/Release Uplift Approval Request
* **User impact if declined**: Impact to an experiment we wanted to run. I'm aware this is an uplift in RC, and not totally sure if that's reasonable or not, but I think with how small of a change this is, it felt like worth a try given the impact of the experiment.
* **Is this code covered by automated tests?**: Yes
* **Has the fix been verified in Nightly?**: No
* **Needs manual test from QE?**: Yes
* **If yes, steps to reproduce**: 1. Set extensions.pocket.loggedOutVariant to "button_variant"
2. be logged out of Pocket
3. Try to save a link
4. In the doorhanger log in prompt, click the "sign up" button

Expected: It should take you to a page with multiple sign up options.
* **List of other uplifts needed**: None
* **Risk to taking this patch**: Low
* **Why is the change risky/not risky? (and alternatives if risky)**: It's a 1 line fix to update a url param that's behind a pref, so should be really low risk.
* **String changes made/needed**: None

Back to Bug 1692324 Comment 6