1692324 - Fix link to signup button for 1 button variant

Status: VERIFIED FIXED

(Firefox :: Pocket, defect)

Description

[Scott [:thecount] Downe]

We're linking the one button variant to the signup link for just email, we should instead link to the signup that has all options.

Comment 1

[Scott [:thecount] Downe]

Attachment: Bug 1692324 - Fixing save to Pocket button one button variant link.

Comment 2

[Scott [:thecount] Downe]

[Tracking Requested - why for this release]:

We noticed a signup url param for a study we intended to run is wrong.

It's a 1 line change, wondering if it's possible to get this into the RC build or not.

Comment 3

[Scott [:thecount] Downe]

To test:

1. Set extensions.pocket.loggedOutVariant to "button_variant"
2. be logged out of Pocket
3. Try to save a link
4. In the doorhanger log in prompt, click the "sign up" button

Expected: It should take you to a page with multiple sign up options.

Attaching screenshot of what the page should look like.

Comment 4

[Scott [:thecount] Downe]

Attachment: signup-options.png

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d14a46f62117
Fixing save to Pocket button one button variant link. r=gvn

Comment 6

[Scott [:thecount] Downe]

Comment on attachment 9202709 [details]
Bug 1692324 - Fixing save to Pocket button one button variant link.

Beta/Release Uplift Approval Request

• User impact if declined: Impact to an experiment we wanted to run. I'm aware this is an uplift in RC, and not totally sure if that's reasonable or not, but I think with how small of a change this is, it felt like worth a try given the impact of the experiment.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Set extensions.pocket.loggedOutVariant to "button_variant"

2. be logged out of Pocket
3. Try to save a link
4. In the doorhanger log in prompt, click the "sign up" button

Expected: It should take you to a page with multiple sign up options.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's a 1 line fix to update a url param that's behind a pref, so should be really low risk.
• String changes made/needed: None

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/d14a46f62117

Comment 8

[Pascal Chevrel (relman team) -> :pascalc]

Comment on attachment 9202709 [details]
Bug 1692324 - Fixing save to Pocket button one button variant link.

Looks very safe to me, let's take it on the beta branch before the merge, thanks.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/5edaae56d77a

Comment 10

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (87.0a1 Build ID - 20210214213026) installed on Windows 10 x64, macOS 10.15.7, and Linux Mint 20 x64. Now, I can confirm that the "Pocket" sign up page from comment 4 is opened after the "Sign up" button from the "Saved to Pocket" doorhanger is clicked.

Comment 11

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Beta (86.0 Build ID - 20210215141125) installed on Windows 10 x64, macOS 10.15.7, and Linux Mint 20 x64. Now, I can confirm that the "Pocket" sign-up page from comment 4 is opened after the "Sign up" button from the "Saved to Pocket" doorhanger is clicked.