Bug 1696377 Comment 1 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

I can reproduce. When I add a tag, it clears the contents of the suggested tags box, and leaves an empty box. We also clear the Remove Page link, tag input, and View List link, making room for the "tags added" dialog.

My guess is why we clear these is because it's a generic dialog messaging system that's used for displaying "tags added", and a few other messages. given the placement of the messages, it also removes the tag input box. Having suggested tags displayed with not tag input box would be weird, so it also takes the suggested tags with it, and I guess because of the old height calculation system made updating the panel height hard, that it just left the empty box.

With the mutation observer for height updates, we can remove this now.
I can reproduce. When I add a tag, it clears the contents of the suggested tags box, and leaves an empty box. We also clear the Remove Page link, tag input, and View List link, making room for the "tags added" dialog.

My guess is why we clear these is because it's a generic dialog messaging system that's used for displaying "tags added", and a few other messages. given the placement of the messages, it also removes the tag input box. Having suggested tags displayed with not tag input box would be weird, so it also takes the suggested tags with it, and I guess because of the old height calculation system made updating the panel height hard, that it just left the empty box.

With the mutation observer for height updates, we can fix this now.
I can reproduce. When I add a tag, it clears the contents of the suggested tags box, and leaves an empty box. We also clear the Remove Page link, tag input, and View List link, making room for the "tags added" dialog.

My guess is why we clear these is because it's a generic dialog messaging system that's used for displaying "tags added", and a few other messages. given the placement of the messages, it also removes the tag input box. Having suggested tags displayed with no tag input box would be weird, so it also takes the suggested tags with it, and I guess because of the old height calculation system made updating the panel height hard, that it just left the empty box.

With the mutation observer for height updates, we can fix this now.

Back to Bug 1696377 Comment 1