1696377 - [Enhancement] Consider changing the size of the “Tags Added” doorhanger to be smaller for premium accounts

Status: NEW

(Firefox :: Pocket, enhancement)

Description

[Maria Heres, inactive, contact Ecosystem QA]

Attachment: empty space doorhanger.gif

[Affected versions]:

• Firefox Release 86.0 (Build ID: 20210222142601)
• Firefox Beta 87.0b5 (Build ID: 20210302185821)
• Firefox Nightly 88.0a1 (Build ID: 20210303215027)

[Affected Platforms]:

• Windows 10
• Linux Mint 20
• macOS 10.15

[Prerequisites]:

• Have a premium Pocket account.
• Have a few tags already saved.

[Steps to reproduce]:

1. Log into Pocket using the premium account.
2. Save a page which will have pocket recommend tags for it.
3. Add a new tag and click the “Save” button.
4. Observe the “Tags Added” doorhanger displayed.

[Proposed result]:

• The doorhanger has the appropriate size for its content.

[Current result]:

• The doorhanger is comprised of two elements, one of them empty of content.

[Notes]:

• The issue is also reproducible after the “We were unable to find any suggested tags for this item.” message is displayed.
• The issue is not reproducible for cases where tags are not recommended (non-premium accounts).
• Attached is a recording of the issue.

Comment 1

[Scott [:thecount] Downe]

I can reproduce. When I add a tag, it clears the contents of the suggested tags box, and leaves an empty box. We also clear the Remove Page link, tag input, and View List link, making room for the "tags added" dialog.

My guess is why we clear these is because it's a generic dialog messaging system that's used for displaying "tags added", and a few other messages. given the placement of the messages, it also removes the tag input box. Having suggested tags displayed with no tag input box would be weird, so it also takes the suggested tags with it, and I guess because of the old height calculation system made updating the panel height hard, that it just left the empty box.

With the mutation observer for height updates, we can fix this now.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Clear a needinfo that is pending on an inactive user.

Inactive users most likely will not respond; if the missing information is essential and cannot be collected another way, the bug maybe should be closed as INCOMPLETE.

For more information, please visit BugBot documentation.