Bug 1697484 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

The strings for the password panel are in https://searchfox.org/mozilla-central/rev/2b99ea2e97eef00a8a1c7e24e5fe51ab5304bc42/toolkit/locales/en-US/chrome/passwordmgr/passwordmgr.properties#5-47

Do not port these strings to Fluent - PopupNotifications, which powers the password panels, is pretty tightly coupled to how .properties files work, so per flod, we're going to bump porting these to Fluent for now.

Note that the string IDs will need to be bumped. Also note that if string interpolation changes (like for `saveLoginMsg` and `saveLoginMsgNoUser`) with insertion points being removed, that you'll need to update the code that uses that string to pass the correct formatted string arguments in.

We know we want to change:

* `saveLoginMsg` should be changed to `Save login for %S?`
* `saveLoginMsgNoUser` should be changed to `Save password for %S?`
* `saveLoginButtonDeny.label` should be changed to `Don't save` - this is a casing change, so the string ID does not need to change.
* `saveLoginButtonNever.label` should be changed to `Never save` - this is a casing change, so the string ID does not need to change.

I'm less sure of the following strings - I'm going to run these by betsymikal, and will update these as I get more information:

* `updateLoginMsg` should be changed to `Update this login?`
* `updateLoginMsgNoUser` should be changed to `Update this password?`
* `updateLoginMsgAddUsername` should be changed to  `Add a username to the saved password?`
* `updateLoginButtonDeny.label` should be changed to `Don’t update` - this is a casing change, so the string ID does not need to change.
* `updateLoginButtonDelete.label` should be changed to `Remove saved login`
The strings for the password panel are in https://searchfox.org/mozilla-central/rev/2b99ea2e97eef00a8a1c7e24e5fe51ab5304bc42/toolkit/locales/en-US/chrome/passwordmgr/passwordmgr.properties#5-47

Do not port these strings to Fluent - PopupNotifications, which powers the password panels, is pretty tightly coupled to how .properties files work, so per flod, we're going to bump porting these to Fluent for now.

Note that the string IDs will need to be bumped. Also note that if string interpolation changes (like for `saveLoginMsg` and `saveLoginMsgNoUser`) with insertion points being removed, that you'll need to update the code that uses that string to pass the correct formatted string arguments in.

We know we want to change:

* `saveLoginMsg` should be changed to `Save login for %S?`
* `saveLoginMsgNoUser` should be changed to `Save password for %S?`
* `saveLoginButtonDeny.label` should be changed to `Don't save` - this is a casing change, so the string ID does not need to change.
* `saveLoginButtonNever.label` should be changed to `Never save` - this is a casing change, so the string ID does not need to change.
* `updateLoginMsg` should be changed to `Update this login?`
* `updateLoginMsgNoUser` should be changed to `Update this password?`
* `updateLoginMsgAddUsername` should be changed to  `Add username to saved password?`
* `updateLoginButtonDeny.label` should be changed to `Don’t update` - this is a casing change, so the string ID does not need to change.
* `updateLoginButtonDelete.label` should be changed to `Remove saved login`

Back to Bug 1697484 Comment 0