Closed
Bug 1697484
Opened 2 years ago
Closed 2 years ago
Update copy for password panels
Categories
(Toolkit :: Password Manager, task, P3)
Toolkit
Password Manager
Tracking
()
RESOLVED
FIXED
88 Branch
Tracking | Status | |
---|---|---|
firefox88 | --- | fixed |
People
(Reporter: mconley, Assigned: mconley)
References
(Blocks 1 open bug)
Details
(Keywords: helpwanted, Whiteboard: [proton-door-hangers])
Attachments
(1 file)
The strings for the password panel are in https://searchfox.org/mozilla-central/rev/2b99ea2e97eef00a8a1c7e24e5fe51ab5304bc42/toolkit/locales/en-US/chrome/passwordmgr/passwordmgr.properties#5-47
Do not port these strings to Fluent - PopupNotifications, which powers the password panels, is pretty tightly coupled to how .properties files work, so per flod, we're going to bump porting these to Fluent for now.
Note that the string IDs will need to be bumped. Also note that if string interpolation changes (like for saveLoginMsg
and saveLoginMsgNoUser
) with insertion points being removed, that you'll need to update the code that uses that string to pass the correct formatted string arguments in.
We know we want to change:
saveLoginMsg
should be changed toSave login for %S?
saveLoginMsgNoUser
should be changed toSave password for %S?
saveLoginButtonDeny.label
should be changed toDon't save
- this is a casing change, so the string ID does not need to change.saveLoginButtonNever.label
should be changed toNever save
- this is a casing change, so the string ID does not need to change.updateLoginMsg
should be changed toUpdate this login?
updateLoginMsgNoUser
should be changed toUpdate this password?
updateLoginMsgAddUsername
should be changed toAdd username to saved password?
updateLoginButtonDeny.label
should be changed toDon’t update
- this is a casing change, so the string ID does not need to change.updateLoginButtonDelete.label
should be changed toRemove saved login
Updated•2 years ago
|
See Also: → https://jira.mozilla.com/browse/FIDEFE-479
Assignee | ||
Updated•2 years ago
|
Assignee: nobody → mconley
Assignee | ||
Comment 1•2 years ago
|
||
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bcdf461c94db Update copy for Add/Update Password panel. r=sfoster,flod
Comment 3•2 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox88:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•