(In reply to Tim Nguyen :ntim from comment #3) > Ah sorry, I just saw I had toggled `media.videocontrols.picture-in-picture.video-toggle.always-show` locally a while ago. Thanks! That did it :) I discussed this with Swapnik over Matix earlier but wanted to reiterate it here for visibility. He proposed that we should hide the PiP toggle button if the source video has no video duration (or is just invalid) regardless of the pref setting. To do this, we might want to start looking at [showShowPictureInPictureToggle](https://searchfox.org/mozilla-central/rev/491c8096b5dfdb328b2135895062e16e1e36d708/toolkit/content/widgets/videocontrols.js#151) and update the checks to include a valid video duration.
Bug 1697616 Comment 4 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
(In reply to Tim Nguyen :ntim from comment #3) > Ah sorry, I just saw I had toggled `media.videocontrols.picture-in-picture.video-toggle.always-show` locally a while ago. Thanks! That did it :) I discussed this with Swapnik over Matix earlier but wanted to reiterate it here for visibility. He proposed that we should hide the PiP toggle button if the source video has no video duration (or is just invalid) regardless of the pref setting. To do this, we might want to start looking at [shouldShowPictureInPictureToggle](https://searchfox.org/mozilla-central/rev/491c8096b5dfdb328b2135895062e16e1e36d708/toolkit/content/widgets/videocontrols.js#151) and update the checks to include a valid video duration.