Bug 1703248 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
__fastfail() exceptions seem to generate **STATUS_STACK_BUFFER_OVERRUN** exceptions that also carry an additional parameter. The latter contains the actual **FAST_FAIL_** subcode. For a CET failure this will be **FAST_FAIL_CONTROL_INVALID_RETURN_ADDRESS** for example. We should include this subcode in the minidump processor output.

We can modify Breakpad's processor handling of [STATUS_STACK_BUFFER_OVERRUN](https://searchfox.org/mozilla-central/rev/d7e344e956d9da2808ea33e1fe0f963ed10c142d/toolkit/crashreporter/google-breakpad/src/processor/minidump_processor.cc#1294-1296) to be more like how we handle [STATUS_ACCESS_VIOLATION](https://searchfox.org/mozilla-central/rev/d7e344e956d9da2808ea33e1fe0f963ed10c142d/toolkit/crashreporter/google-breakpad/src/processor/minidump_processor.cc#1161-1195) failures that print both the main exception code and the subcode.

Note: this bug tracks the changes that need to be done in mozilla-central. Once landed the changes should also be applied to Socorro's stackwalker. I will file an additional bug on GitHub to track that work.
Revision 1 by
on 
__fastfail() exceptions seem to generate **STATUS_STACK_BUFFER_OVERRUN** exceptions that also carry an additional parameter. The latter contains the actual **FAST_FAIL** subcode. For a CET failure this will be **FAST_FAIL_CONTROL_INVALID_RETURN_ADDRESS** for example. We should include this subcode in the minidump processor output.

We can modify Breakpad's processor handling of [STATUS_STACK_BUFFER_OVERRUN](https://searchfox.org/mozilla-central/rev/d7e344e956d9da2808ea33e1fe0f963ed10c142d/toolkit/crashreporter/google-breakpad/src/processor/minidump_processor.cc#1294-1296) to be more like how we handle [STATUS_ACCESS_VIOLATION](https://searchfox.org/mozilla-central/rev/d7e344e956d9da2808ea33e1fe0f963ed10c142d/toolkit/crashreporter/google-breakpad/src/processor/minidump_processor.cc#1161-1195) failures that print both the main exception code and the subcode.

Note: this bug tracks the changes that need to be done in mozilla-central. Once landed the changes should also be applied to Socorro's stackwalker. I will file an additional bug on GitHub to track that work.

Back to Bug 1703248 Comment 0