1703248 - Print the exception subcode of EXCEPTION_STACK_BUFFER_OVERRUN crashes

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, enhancement)

Description

[Gabriele Svelto [:gsvelto]]

__fastfail() exceptions seem to generate STATUS_STACK_BUFFER_OVERRUN exceptions that also carry an additional parameter. The latter contains the actual FAST_FAIL subcode. For a CET failure this will be FAST_FAIL_CONTROL_INVALID_RETURN_ADDRESS for example. We should include this subcode in the minidump processor output.

We can modify Breakpad's processor handling of STATUS_STACK_BUFFER_OVERRUN to be more like how we handle STATUS_ACCESS_VIOLATION failures that print both the main exception code and the subcode.

Note: this bug tracks the changes that need to be done in mozilla-central. Once landed the changes should also be applied to Socorro's stackwalker. I will file an additional bug on GitHub to track that work.

Comment 1

[Gabriele Svelto [:gsvelto]]

Small correction, STATUS_STACK_BUFFER_OVERRUN exceptions might come with one or more additional parameters (I've found up to 3 by looking at a random set of crashes). However the FAST_FAIL subcode is always stored in the first additional parameter.

Comment 2

[Gabriele Svelto [:gsvelto]]

Attachment: Bug 1703248 - Print the exception subcode of EXCEPTION_STACK_BUFFER_OVERRUN crashes r=KrisWright

This is the crashes that are usually caused by a __fastfail() invocation

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eef92ede2109
Print the exception subcode of EXCEPTION_STACK_BUFFER_OVERRUN crashes r=KrisWright

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/eef92ede2109