Bug 1704431 Comment 1 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
[wr_renderer_update(mRenderer)](https://searchfox.org/mozilla-central/rev/fa48ebee58d59fa846919c3e2c3122b08db57c9c/gfx/webrender_bindings/RendererOGL.cpp#173) is called after mCompositor->BeginFrame(). But wr_renderer_update() could call [render_impl()}(https://searchfox.org/mozilla-central/rev/fa48ebee58d59fa846919c3e2c3122b08db57c9c/gfx/wr/webrender/src/renderer/mod.rs#1540). StartCompositing() is ccalled under render_impl(), but it is not expected for StartCompositing().
Revision 1 by
on 
[wr_renderer_update(mRenderer)](https://searchfox.org/mozilla-central/rev/fa48ebee58d59fa846919c3e2c3122b08db57c9c/gfx/webrender_bindings/RendererOGL.cpp#173) is called after mCompositor->BeginFrame(). But wr_renderer_update() could call [render_impl()](https://searchfox.org/mozilla-central/rev/fa48ebee58d59fa846919c3e2c3122b08db57c9c/gfx/wr/webrender/src/renderer/mod.rs#1540). StartCompositing() is ccalled under render_impl(), but it is not expected for StartCompositing().
Revision 2 by
on 
[wr_renderer_update(mRenderer)](https://searchfox.org/mozilla-central/rev/fa48ebee58d59fa846919c3e2c3122b08db57c9c/gfx/webrender_bindings/RendererOGL.cpp#173) is called after mCompositor->BeginFrame(). But wr_renderer_update() could call [render_impl()](https://searchfox.org/mozilla-central/rev/fa48ebee58d59fa846919c3e2c3122b08db57c9c/gfx/wr/webrender/src/renderer/mod.rs#1540). StartCompositing() is ccalled under render_impl(), but it is not expected for RenderCompositorLayersSWG.
Revision 3 by
on 
[wr_renderer_update(mRenderer)](https://searchfox.org/mozilla-central/rev/fa48ebee58d59fa846919c3e2c3122b08db57c9c/gfx/webrender_bindings/RendererOGL.cpp#173) is called after mCompositor->BeginFrame(). But wr_renderer_update() could call [render_impl()](https://searchfox.org/mozilla-central/rev/fa48ebee58d59fa846919c3e2c3122b08db57c9c/gfx/wr/webrender/src/renderer/mod.rs#1540). StartCompositing() is called under render_impl(), but it is not expected for RenderCompositorLayersSWG.

Back to Bug 1704431 Comment 1