Closed
Bug 1704431
Opened 4 years ago
Closed 4 years ago
RenderCompositorLayersSWGL::StartCompositing() was called multiple times before RenderCompositorLayersSWGL::EndFrame()
Categories
(Core :: Graphics: WebRender, defect)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
89 Branch
| Tracking | Status | |
|---|---|---|
| firefox89 | --- | fixed |
People
(Reporter: sotaro, Assigned: sotaro)
References
Details
Attachments
(1 file)
There was a case that RenderCompositorLayersSWGL::StartCompositing() was called multiple times before RenderCompositorLayersSWGL::EndFrame().
It caused test failure as in Bug 1704000 comment 2.
|
Assignee | |
Comment 1•4 years ago
•
|
||
wr_renderer_update(mRenderer) is called after mCompositor->BeginFrame(). But wr_renderer_update() could call render_impl(). StartCompositing() is called under render_impl(), but it is not expected for RenderCompositorLayersSWG.
|
|
Assignee | |
Comment 2•4 years ago
|
||
BeforeWrRender() is added to differentiate
|
|
Assignee | |
Comment 3•4 years ago
|
||
With patch of Bug 1704431, assertion failure was addressed.
https://treeherder.mozilla.org/jobs?repo=try&revision=9547b53ee005742a26a96d7ca946f668c12ace8e
|
||
Updated•4 years ago
|
Attachment #9215039 -
Attachment description: Bug 1704431 - RenderCompositorLayersSWGL::BeforeWrRender() → Bug 1704431 - Add RenderCompositorLayersSWGL::BeforeWrRender() call just before wr_renderer_render().
|
|
||
Updated•4 years ago
|
Attachment #9215039 -
Attachment description: Bug 1704431 - Add RenderCompositorLayersSWGL::BeforeWrRender() call just before wr_renderer_render(). → Bug 1704431 - Add RenderCompositorLayersSWGL::BeforeWrRender() call just before wr_renderer_render()
|
|
||
Updated•4 years ago
|
Attachment #9215039 -
Attachment description: Bug 1704431 - Add RenderCompositorLayersSWGL::BeforeWrRender() call just before wr_renderer_render() → WIP: Bug 1704431 - Handle start compositing only when dirty rect exists
|
|
||
Updated•4 years ago
|
Attachment #9215039 -
Attachment description: WIP: Bug 1704431 - Handle start compositing only when dirty rect exists → Bug 1704431 - Handle start compositing only when dirty rect exists
|
|
Assignee | |
Comment 4•4 years ago
|
||
Pushed by sikeda.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d41e799d6e62
Handle start compositing only when dirty rect exists r=lsalzman,gfx-reviewers
|
||
Comment 6•4 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox89:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•