Bug 1712811 Comment 3 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
The main thing going on here is that a `mozilla/Variant.h` include is missing in `QuotaCommon.h`. But it's only needed when `QM_ERROR_STACKS_ENABLED` is defined. Which it is only when if `defined(EARLY_BETA_OR_EARLIER) || defined(DEBUG)` as per the definition in `QMResult.h`. But then there are many blocks doing
```
#if defined(EARLY_BETA_OR_EARLIER) || defined(DEBUG)
...
#  ifdef QM_ERROR_STACKS_ENABLED
...
#  else
...
#  endif
...
#endif
```
where the else part is never going to be used.
Revision 1 by
on 
The main thing going on here is that a `mozilla/Variant.h` include is missing in `QuotaCommon.h`. But it's only needed when `QM_ERROR_STACKS_ENABLED` is defined. Which it is only when if `defined(EARLY_BETA_OR_EARLIER) || defined(DEBUG)` as per the definition in `QMResult.h`. But then there are many blocks doing
```
#if defined(EARLY_BETA_OR_EARLIER) || defined(DEBUG)
...
#  ifdef QM_ERROR_STACKS_ENABLED
...
#  else
...
#  endif
...
#endif
```
where the else part is never going to be used, which also means `Maybe.h` is never used.

Back to Bug 1712811 Comment 3