1712811 - QuotaCommon.h:1324:62: error: invalid use of incomplete type

Status: RESOLVED FIXED

(Core :: Storage: Quota Manager, defect, P2)

Description

[Petr Sumbera]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:88.0) Gecko/20100101 Firefox/88.0

Steps to reproduce:

Solaris builds fails with:

 6:44.09 /builds/psumbera/mozilla-central-build/dom/indexedDB/test/gtest/TestFileInfo.cpp:185:30:   required from here
 6:44.09 /builds/psumbera/mozilla-central-build/obj-x86_64-pc-solaris2.11/dist/include/mozilla/dom/quota/QuotaCommon.h:1324:62: error: invalid use of incomplete type 'using ResultType = class mozilla::Variant<mozilla::QMResult, nsresult, mozilla::Nothing>' {aka 'class mozilla::Variant<mozilla::QMResult, nsresult, mozilla::Nothing>'}
 6:44.09  1324 |     mozilla::dom::quota::LogError(nsDependentCString(aExpr), ResultType(aRv),
 6:44.09       |                                                              ^~~~~~~~~~~~~~~

The first bad revision is:
changeset: 580568:08b0dccfddf7
user: Masayuki Nakano <[e-mail]>
date: Tue May 25 06:46:18 2021 +0000
description:
Bug 1540037 - part 20: Move UndoAsAction() and RedoAsAction() from TextEditor to EditorBase r=m_kato

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Storage: IndexedDB' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Jens Stutte [:jstutte]]

Probably the next child revision looks more related.

Comment 3

[Mike Hommey [:glandium]]

The main thing going on here is that a mozilla/Variant.h include is missing in QuotaCommon.h. But it's only needed when QM_ERROR_STACKS_ENABLED is defined. Which it is only when if defined(EARLY_BETA_OR_EARLIER) || defined(DEBUG) as per the definition in QMResult.h. But then there are many blocks doing

#if defined(EARLY_BETA_OR_EARLIER) || defined(DEBUG)
...
#  ifdef QM_ERROR_STACKS_ENABLED
...
#  else
...
#  endif
...
#endif

where the else part is never going to be used, which also means Maybe.h is never used.

Comment 4

[Jens Stutte [:jstutte]]

Thanks, Jan already spotted this, too. Patch is on the way on the regressing bug.

Comment 5

[Dan Horák]

Petr, you have beaten me again :-)

Comment 6

[Jan Varga [:janv]]

(In reply to Mike Hommey [:glandium] from comment #3)

where the else part is never going to be used, which also means Maybe.h is never used.

Maybe.h is also needed for ToMaybeRef in QuotaCommon.h

I submitted a patch to add the missing include.

Comment 7

[Dan Horák]

Jan, FYI your patch(es) hasn't fixed the issue for me (Fedora 32 on ppc64le).

Comment 8

[Petr Sumbera]

(In reply to Dan Horák from comment #7)

Jan, FYI your patch(es) hasn't fixed the issue for me (Fedora 32 on ppc64le).

It worked for me with following addition (as MIke suggested above):

--- a/dom/quota/QuotaCommon.h   Wed May 12 01:05:20 2021 -0700
+++ b/dom/quota/QuotaCommon.h   Thu May 27 08:13:38 2021 +0000
@@ -22,6 +22,7 @@
 #include "mozilla/Maybe.h"
 #include "mozilla/Result.h"
 #include "mozilla/ResultExtensions.h"
+#include "mozilla/Variant.h"
 #include "mozilla/ThreadLocal.h"
 #include "mozilla/dom/QMResult.h"
 #include "mozilla/ipc/ProtocolUtils.h"

Comment 9

[Dan Horák]

Yup, that fixes the issue. The conditional include from https://phabricator.services.mozilla.com/D116121 doesn't seem to be right.

Comment 10

[Jan Varga [:janv]]

I know what's wrong. QMResult.h must be included before that.

Comment 11

[Jan Varga [:janv]]

(In reply to Jan Varga [:janv] from comment #10)

I know what's wrong. QMResult.h must be included before that.

I updated the patch in Phab, can someone re-test it ?
Thanks.

Comment 12

[Petr Sumbera]

(In reply to Jan Varga [:janv] from comment #11)

I updated the patch in Phab, can someone re-test it ?

Works for me.

Comment 13

[Jan Varga [:janv]]

A fix for this landed in the original bug 1709352.
Exact patch: https://phabricator.services.mozilla.com/D116121