Bug 1719539 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Steps to test:

1. In an artifact debug build, start the browser
2. Browse to about:preferences. This causes the browser to “process flip” and load content in the parent process
3. Browse that same tab to about:pocket-saved
4. Browser should crash.

This was found via a new test added in bug 1714749

Mike Conley helped me debug this one, and suspected it's due to about:pocket-* not being in this list: https://searchfox.org/mozilla-central/rev/94d6086481754e154b6f042820afab6bc9900a30/dom/security/nsContentSecurityUtils.cpp#954-967

Specifically about:pocket-saved is the issue because of this line https://searchfox.org/mozilla-central/source/browser/components/pocket/content/panels/saved.html#5

Doing it in debug more is the key to getting it to crash.

We didn't detect this until now, because of the test added in bug 1714749

I believe we just need to add about:pocket-* to the list in nsContentSecurityUtils.cpp
Steps to test:

1. In an artifact debug build, start the browser
2. Browse to about:preferences. This causes the browser to “process flip” and load content in the parent process
3. Browse that same tab to about:pocket-saved
4. Browser should crash.

This was found via a new test added in bug 1714749

Mike Conley helped me debug this one, and suspected it's due to about:pocket-* not being in this list: https://searchfox.org/mozilla-central/rev/94d6086481754e154b6f042820afab6bc9900a30/dom/security/nsContentSecurityUtils.cpp#954-967

Specifically about:pocket-saved is the issue because of this line https://searchfox.org/mozilla-central/source/browser/components/pocket/content/panels/saved.html#5

Doing it in debug more is the key to getting it to crash.

We didn't detect this until now, because of the test added in bug 1714749

I believe we just need to add the about:pocket-* pages to the list in nsContentSecurityUtils.cpp

Back to Bug 1719539 Comment 0