1714749 - Pocket icon has inconsistent status in Firefox 89

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect)

Description

[fthebaud]

Attachment: Screenshot 2021-06-05 115915.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:89.0) Gecko/20100101 Firefox/89.0

Steps to reproduce:

Firefox 89 is opened with two tabs.
1 - I click on the 'save to pocket' icon when I'm on the first tab.
2 - Then I switch to the second tab.
3 - Finally I switch back to the first tab.

Actual results:

1 - The pocket icon turns red, indicating that the tab is saved.
2 - The pocket icon turns red too, incorrectly indicating that the tab is saved
3 - The pocket icon has been reset to black, incorrectly indicating that the tab is not saved

Expected results:

1 - ok, this is the correct behavior
2 - Pocket icon should stay dark when I move to another tab that has not been saved.
3 - When going back to a saved tab, the pocket icon should reflect the saved status (this last one is more an enhancement, as I think we had this behavior before Firefox 89)
Basically the pocket icon should always reflect the status of the tab (saved or not in pocket)

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::New Tab Page' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Robert Martin [:romartin], Ecosystem QA]

Hello @fthebaud,

I cannot reproduce the issue by following the steps you've provided.

If you still reproduce the issue, can you please try to open the same Firefox browser using a new profile and let us know if you still manage to reproduce it? For details on how to open the Firefox browser using a new profile see this link.

If the issue is not reproducible on the new Firefox profile, I would like to ask you to share the "about:support" page of the profile that is affected by this issue. In order to do this follow these steps:

1. Open the Firefox profile.
2. Navigate to the "about:support" page.
3. Copy the entire page content (You can use CTRL+A to select the page and CTRL+C to copy the content selected).
4. Paste the content in a text file and add it as attachment or paste the content in a comment on this bug.

Additionally, can you please share the URL's that you are using in order to reproduce the issue?

Thank you in advance!

Comment 3

[fthebaud]

Attachment: about-support

I have two computers, one with Windows 10 and one with Debian.
I can only reproduce the issue on Windows.

Any url will work, but I did my last test with this two urls:
- https://www.mozilla.org/en-US/firefox/browsers/
- https://www.mozilla.org/en-US/privacy/firefox/

Comment 4

[fthebaud]

I have two computers, one with Windows 10 and one with Debian.
I can only reproduce the issue on Windows.

Any url will work, but I did my last test with this two urls:

• https://www.mozilla.org/en-US/firefox/browsers/
• https://www.mozilla.org/en-US/privacy/firefox/

Comment 5

[Robert Martin [:romartin], Ecosystem QA]

Hello @fthebaud,

Thank you for the extra information!

I've managed to reproduce the issue by using the following steps:

[Steps to Reproduce]:

1. Log in to a Pocket account.
2. Open a New Tab page and navigate to any website (e.g. www.wikipedia.org).
3. Open another New Tab page and navigate to another website (e.g. www.reddit.com).
4. On the Wikipedia tab click the "Save to Pocket" button.
5. Without dismissing the "Save to Pocket" doorhanger, switch to the Reddit tab and observe the "Save to Pocket" button.

[Expected results]:

• The "Save to Pocket" button from the Wikipedia tab turns red indicating that the page is saved to Pocket.
• The "Save to Pocket" button from the Reddit tab is still the default one indicating that the page is NOT saved to Pocket.

[Actual results]:

• The "Save to Pocket" button from the Wikipedia tab is still the default one indicating that the page is NOT saved to Pocket.
• The "Save to Pocket" button from the Reddit tab is red wrongly indicating that the page is saved to Pocket.

[Regression Window]:

• Since the issue is not reproducible with Firefox Release 88.0, using the Mozregression tool I've managed to find the following regression window:
  16:09.77 INFO: Last good revision: 9768659de9578807afd741533dc0be9cc02d3634 16:09.77 INFO: First bad revision: 94729075e1a328aa06e716beede2582542c994c5 16:09.77 INFO: Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=9768659de9578807afd741533dc0be9cc02d3634&tochange=94729075e1a328aa06e716beede2582542c994c5

From the pushlog it seems that bug 1693376 has caused this behavior.

[Notes]:

• The issue is not reproducible if the doorhanger is dismissed after the page is saved. E.g. clicking outside the doorhanger after the page is saved.
• The issue is reproducible on macOS 11.3.1, and Windows 10 x64, however it is not reproducible on Ubuntu Linux 20.04 x64.
• The pages are correctly saved to "My List".

@Scott, can you please weigh in on this?

Comment 6

[Scott [:thecount] Downe]

Attachment: Bug 1714749 - Fixing Pocket icon state.

Comment 7

[Scott [:thecount] Downe]

I put some steps to test in the patch, but wanted to share that here too for QA purposes.

1. Log into Pocket.
2. Open two tabs each with some random article from newtab. Or some other page.
3. Go to the first tab.
4. Save it by clicking the save to Pocket button.
5. With the Pocket panel still open, click ctrl+tab to switch to the next tab, this might be different on a mac.

Expected. The Pocket panel should close, and the Pocket button icon should not be red.

Also some good regression tests I did are.

1. Save a page, and close the panel, if the page was saved, the icon should stay red.
2. Switch tabs after saving an article, and saved pages should show a red Pocket icon, and not saved pages should not.
3. Try saving a page and closing the panel before it saves, this should not produce a red icon.
4. The icon should be red while the panel is open.
5. Try clicking "remove page" from inside the Pocket panel, icon should go back to not being red.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/19efa711bd54
Fixing Pocket icon state. r=gvn,mconley

Comment 9

[Atila Butkovits]

Backed out for causing assertion failures at foundWebScheme.

Backout link: https://hg.mozilla.org/integration/autoland/rev/b493f282a582f558d4e6cd116390f57b04f9a4aa

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&revision=e806428569824e8b75664663ad5289ad5c6a3c31&searchStr=windows%2C10%2Cx64%2Cwebrender%2Cdebug%2Cmochitests%2Ctest-windows10-64-qr%2Fdebug-mochitest-browser-chrome-e10s%2Cbc4&selectedTaskRun=YsZYh8e8Q6mcu8rF2taKgw.0

Failure log: https://treeherder.mozilla.org/jobs?repo=autoland&revision=e806428569824e8b75664663ad5289ad5c6a3c31&searchStr=windows%2C10%2Cx64%2Cwebrender%2Cdebug%2Cmochitests%2Ctest-windows10-64-qr%2Fdebug-mochitest-browser-chrome-e10s%2Cbc4&selectedTaskRun=YsZYh8e8Q6mcu8rF2taKgw.0

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/791632616bbe
Fixing Pocket icon state. r=gvn,mconley

Comment 11

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/791632616bbe

Comment 13

[Rares Doghi, Desktop QA]

This issue is Verified as fixed In our latest Beta 91.0b2 on Windows as well as Mac.