Bug 1721217 Comment 1 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

I have a patch for bug 1720958 and with the pref enabled, there are a bunch of tests failing. I need to audit the test failures and see which failures simply require test changes or small fixes in existing parent-initiated-load codepath, and which ones will be fixed once we implement parent-initiated CanonicalBrowsingContext::Reload (bug 1672589) , as well as parent initiated Forward/Back/Go methods (more [here](https://bugzilla.mozilla.org/show_bug.cgi?id=1672589#c0)). 

From my understanding, when Matt was trying to land the parent controlled loads there was only one (geckoview) test that was failing because it started a load and then right away issued a reload. As per convo with Matt "If the load request is handled in the parent, but the reload is forward onto whatever previous content process existed, then the reload finds about:blank and doesn't do anything. This can't really happen on desktop (since the combined stop/reload button will be showing stop, not reload during that time), but it's possible extensions or something might have this issue"
I have a patch for bug 1720958 and with the pref enabled, there are a bunch of tests failing. I need to audit the test failures and see which failures simply require test changes or small fixes in existing parent-initiated-load codepath (fix them in this bug), and which ones will be fixed once we implement parent-initiated CanonicalBrowsingContext::Reload (bug 1672589) , as well as parent initiated Forward/Back/Go methods (more [here](https://bugzilla.mozilla.org/show_bug.cgi?id=1672589#c0)). 

From my understanding, when Matt was trying to land the parent controlled loads there was only one (geckoview) test that was failing because it started a load and then right away issued a reload. As per convo with Matt "If the load request is handled in the parent, but the reload is forward onto whatever previous content process existed, then the reload finds about:blank and doesn't do anything. This can't really happen on desktop (since the combined stop/reload button will be showing stop, not reload during that time), but it's possible extensions or something might have this issue"
I have a patch for bug 1720958 and with the pref enabled, there are a bunch of tests failing. I need to audit the test failures and see which failures simply require test changes or small fixes in existing parent-initiated-load codepath (I can fix them in this bug), and which ones will be fixed once we implement parent-initiated CanonicalBrowsingContext::Reload (bug 1672589) , as well as parent initiated Forward/Back/Go methods (more [here](https://bugzilla.mozilla.org/show_bug.cgi?id=1672589#c0)). 

From my understanding, when Matt was trying to land the parent controlled loads there was only one (geckoview) test that was failing because it started a load and then right away issued a reload. As per convo with Matt "If the load request is handled in the parent, but the reload is forward onto whatever previous content process existed, then the reload finds about:blank and doesn't do anything. This can't really happen on desktop (since the combined stop/reload button will be showing stop, not reload during that time), but it's possible extensions or something might have this issue"

Back to Bug 1721217 Comment 1