1672589 - Implement CanonicalBrowsingContext::Reload using SHIP

Status: ASSIGNED

(Core :: DOM: Navigation, task, P3)

Description

[Matt Woodrow (:mattwoodrow)]

Current CBC::Reload sends a reload message to the content process docshell, which then immediately sends NotifyOnHistoryReload back to the CBC.

We should instead be able to run NotifyOnHistoryReload immediately, compute an nsDocShellLoadState, and then call CanonicalBrowsingContext::LoadURI to start loading it immediately in the parent process.

Some other corner cases:

nsDocShell::LoadHistoryEntry can show a 'confirm repost' prompt if the history entry had form data. We'd want to make sure we can do this from the parent as well, which it looks like we can.

nsDocShell::LoadHistoryEntry has special handling for javascript: URIs.

nsDocShell::ReloadDocument handles the case where we have no history, but want to just reload the current document. It computes an nsDocShellLoadState from the current Document. I think we can reimplement this easily using the current WindowGlobalParent.

We should be able to do something similar for Forward/Back/GoToIndex etc, but I haven't looked at those.

Comment 1

[Neha Kochar [:neha]]

Olli confirmed that this is not a Fission blocker so moving to Future.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

This is tracked through bug 1647550.