Bug 1721308 Comment 1 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Timothy Nikkel (:tnikkel) from comment #0)
> STR:
> 1) Enable restore tabs from last session on start.
> 2) Have two tabs, the first can be anything, the second needs to be a page that when loaded it pops up the "Allow this site to open the <protocol> link?" dialog. For me any link to a podcast on the apple podcast site (eg https://podcasts.apple.com/us/podcast/edith/id1571400332) does that but I can't get a fresh profile to do that, I'm not sure why, someone who knows this area more can maybe provide a page that does that or prefs to flip.
> 3) Select the first tab and close Firefox.
> 4) Restart firefox.
> 5) Click and hold the second tab and drag it in the tab bar, wait until the dialog pops up.
> 
> Trying to click in the url bar will fail and your interactions with the tabbar will probably be broken as well.
> 
> Bisected to https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=f3a829091fef65cf49209ed374688cdd6d5753ed&tochange=66d3efe9fc7a276ba284bb1f98a4e9c3cc53e1fb
> 
> which contains bug 1635709 so I'm guessing it's that, but I didn't look in detail, just looked for drag changes.

The pushlog contains only part 24.1 - part 27 of bug 1635709. My guess is, those part didn't cause this regression, but one needs to bisect to be sure.

Rares: can you please help determining which exact commit caused this regression?
(In reply to Timothy Nikkel (:tnikkel) from comment #0)
> STR:
> 1) Enable restore tabs from last session on start.
> 2) Have two tabs, the first can be anything, the second needs to be a page that when loaded it pops up the "Allow this site to open the <protocol> link?" dialog. For me any link to a podcast on the apple podcast site (eg https://podcasts.apple.com/us/podcast/edith/id1571400332) does that but I can't get a fresh profile to do that, I'm not sure why, someone who knows this area more can maybe provide a page that does that or prefs to flip.
> 3) Select the first tab and close Firefox.
> 4) Restart firefox.
> 5) Click and hold the second tab and drag it in the tab bar, wait until the dialog pops up.
> 
> Trying to click in the url bar will fail and your interactions with the tabbar will probably be broken as well.
> 
> Bisected to https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=f3a829091fef65cf49209ed374688cdd6d5753ed&tochange=66d3efe9fc7a276ba284bb1f98a4e9c3cc53e1fb
> 
> which contains bug 1635709 so I'm guessing it's that, but I didn't look in detail, just looked for drag changes.

The pushlog contains only part 24.1 - part 27 of bug 1635709. My guess is, those parts didn't cause this regression, but one needs to bisect to be sure.

Rares: can you please help determining which exact commit caused this regression?

Back to Bug 1721308 Comment 1