Clean up code around `nsFrameSelection::HandleDrag`
Categories
(Core :: DOM: Selection, enhancement)
Tracking
()
People
(Reporter: mbrodesser-Igalia, Assigned: mbrodesser-Igalia)
References
(Blocks 1 open bug)
Details
Attachments
(30 files, 2 obsolete files)
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
Bug 1635709: part 4) Transform `Selection::DoAutoScroll` to `AutoScroller::DoAutoScroll`. r=masayuki
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review |
Assignee | ||
Comment 1•4 years ago
|
||
The old name was misleading.
Assignee | ||
Comment 2•4 years ago
|
||
Selection
's nsAutoScrollTimer
uses it and it's clearer when the unit
is known.
Depends on D74051
Assignee | ||
Comment 3•4 years ago
|
||
Depends on D74052
Assignee | ||
Updated•4 years ago
|
Comment 5•4 years ago
|
||
bugherder |
Assignee | ||
Comment 6•4 years ago
|
||
Allows defriending AutoScroller
from Selection
and removes the
direct dependency of AutoScroller
to Selection
.
Assignee | ||
Comment 7•4 years ago
|
||
Depends on D74382
Assignee | ||
Comment 8•4 years ago
|
||
nsFrameSelection
has (too) many responsibilites, this adds some
clarification.
Depends on D74383
Assignee | ||
Comment 9•4 years ago
|
||
Depends on D74615
Assignee | ||
Comment 10•4 years ago
|
||
Depends on D74616
Assignee | ||
Comment 11•4 years ago
|
||
Depends on D74617
Comment 12•4 years ago
|
||
Comment 13•4 years ago
|
||
bugherder |
Comment 14•4 years ago
|
||
Assignee | ||
Comment 15•4 years ago
|
||
Assignee | ||
Comment 16•4 years ago
|
||
Depends on D74856
Assignee | ||
Comment 17•4 years ago
|
||
Depends on D74857
Assignee | ||
Comment 18•4 years ago
|
||
Depends on D74858
Comment 19•4 years ago
|
||
bugherder |
Updated•4 years ago
|
Comment 20•4 years ago
|
||
Assignee | ||
Comment 21•4 years ago
|
||
Simplifies reasoning about the code when using searchfox.
Assignee | ||
Comment 22•4 years ago
|
||
Helps to get rid of unnecessary nsresult
s later.
Depends on D75057
Assignee | ||
Comment 23•4 years ago
|
||
Depends on D75058
Comment 24•4 years ago
|
||
Assignee | ||
Comment 25•4 years ago
|
||
The location wasn't used from the caller of
GetTableCellLocationFromRange
.
However, GetTableCellLocationFromRange
included flushing frames, this is now done in
HTMLEditor::CellIndexes::Update
.
Assignee | ||
Comment 26•4 years ago
|
||
Depends on D75098
Assignee | ||
Comment 27•4 years ago
|
||
Depends on D75099
Comment 28•4 years ago
|
||
bugherder |
Comment 29•4 years ago
|
||
bugherder |
Comment 30•4 years ago
|
||
Comment 31•4 years ago
|
||
bugherder |
Assignee | ||
Comment 32•4 years ago
|
||
Assignee | ||
Comment 33•4 years ago
|
||
It's more accurate.
Depends on D75562
Assignee | ||
Comment 34•4 years ago
|
||
Depends on D75563
Assignee | ||
Comment 35•4 years ago
|
||
Depends on D75564
Comment 36•4 years ago
|
||
Comment 37•4 years ago
|
||
bugherder |
Assignee | ||
Comment 38•4 years ago
|
||
Comment 39•4 years ago
|
||
Comment 40•4 years ago
|
||
bugherder |
Assignee | ||
Comment 41•4 years ago
|
||
TableSelection
has fewer responsibilites than nsFrameSelection
. This
simplifies reasoning about TakeFocus
.
Assignee | ||
Comment 42•4 years ago
|
||
HandleSelection
was too complex.
The arguments of the new methods will be renamed in a separate commit to
simplify reviewing and avoid mistakes.
Depends on D77252
Assignee | ||
Comment 43•4 years ago
|
||
Depends on D77253
Assignee | ||
Comment 44•4 years ago
|
||
Assignee | ||
Comment 45•4 years ago
|
||
Depends on D77423
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Assignee | ||
Comment 46•4 years ago
|
||
Simple application of ./mach clang-format -p layout/generic/nsFrameSelection.cpp
. Separating this from previous
changes simplified reviewing and decreases the probability for mistakes.
Depends on D77424
Assignee | ||
Comment 47•4 years ago
|
||
Depends on D77459
Comment 48•4 years ago
|
||
Assignee | ||
Comment 49•4 years ago
|
||
Depends on D77460
Comment 50•4 years ago
|
||
bugherder |
Comment 51•4 years ago
|
||
Comment 52•4 years ago
|
||
bugherder |
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Description
•