Bugzilla

(In reply to :Gijs (he/him) from comment #2)
> (In reply to Daniel Holbert [:dholbert] from comment #1)
> > It looks like the "e" accesskey usage here came from this commit for bug 1692668:
> > https://hg.mozilla.org/integration/autoland/rev/9a043bb287a5#l16.98
> > 
> > Gijs, do you recall why we used "e" instead of "R" for Remove here, and could/should we consider changing it for consistency (at least for this case of the button + bookmarks on the bookmarks toolbar which use different removal accesskeys)?
> 
> `r` is used for Sort already, in the same menu, so you can't just use "R" without more work.. 

Are you sure? I only see "Sort" in "Sort by name", which is in the folder context-menu (e.g. if I right-click a folder in the bookmarks/places organizer).  And in *that* context-menu, "Remove" has yet-another-accesskey, "m".  So there's no strong consistency or collision argument for using "e" as the accesskey for removal action in the individual-bookmark contextmenu, AFAICT...

(In reply to :Gijs (he/him) from comment #2)
> (In reply to Daniel Holbert [:dholbert] from comment #1)
> > It looks like the "e" accesskey usage here came from this commit for bug 1692668:
> > https://hg.mozilla.org/integration/autoland/rev/9a043bb287a5#l16.98
> > 
> > Gijs, do you recall why we used "e" instead of "R" for Remove here, and could/should we consider changing it for consistency (at least for this case of the button + bookmarks on the bookmarks toolbar which use different removal accesskeys)?
> 
> `r` is used for Sort already, in the same menu, so you can't just use "R" without more work.. 

Are you sure? I only see "Sort" in "Sort by name", which is in context-menu for bookmarks *folders* (not individual bookmarks which is the thing involved in this bug's STR).

e.g. if I right-click a folder in the bookmarks/places organizer, I do see `So(r)t by name`; and in *that* context-menu, "Remove" has yet-another-accesskey, "m".  So there's no strong consistency or collision argument for using "e" as the accesskey for removal action in the individual-bookmark contextmenu, AFAICT...