1692668 - [Proton] Update bookmarks context menu for clarity

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, enhancement, P1)

Description

[:Gijs (he/him)]

Specific changes:

• Change "Open All in Tabs" to "Open All Bookmarks"

• Change "New Bookmark/Separator/Folder..." to "Add Bookmark/Separator/Folder..."

• Add "Manage Bookmarks..." item at the bottom of the menu. This should open the library.

• Change the order of the bookmarks toolbar visibility submenu (might happen in bug 1690575)

• Change "Properties" to "Edit Bookmark..." and "Delete" to "Remove Bookmark", and put them in one group immediately after the separator following the "Open In ..." context menu items.

• Keep "Paste" where it is on the empty bookmarks toolbar, but move the Cut/Copy/Paste group before "Add Bookmark/Separator/Folder" when opening the context menu on an existing item (after the group for edit/remove bookmark)

Comment 1

[Erica Wright [:ewright]]

Attachment: Bug 1692668 - Update bookmarks context menu for clarity.

Comment 2

[Blake Winton (:bwinton) (:☕️)]

As per guidance from Vicky, for tracking, we're marking all the bugs that people are working on as P1.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b3df95f06470
Update bookmarks context menu for clarity. r=Gijs,fluent-reviewers,flod

Comment 4

[Atila Butkovits]

Backed out for causing failure at browser_bookmark_change_location.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/423286cb35b56b356f7916d6f24ace108c7d9fb5

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=LLU182N9QH2WoWBo9Xz8Ww.0&searchStr=linux%2C18.04%2Cx64%2Ctsan%2Copt%2Cmochitests%2Ctest-linux1804-64-tsan%2Fopt-mochitest-browser-chrome-e10s%2Cbc20&revision=b3df95f064703359085cdad64678858873b07068

Failure log: https://treeherder.mozilla.org/logviewer?job_id=331384111&repo=autoland&lineNumber=3043

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9a043bb287a5
Update bookmarks context menu for clarity. r=Gijs,fluent-reviewers,flod

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/9a043bb287a5

Comment 7

[Bogdan Maris, Desktop Test Engineering]

Verified that the changes mentioned in comment 0 are indeed reflected in Latest Nightly 88.0a1 across platforms (Windows 10, macOS 11.3 and Ubuntu 18.04) and their functionality is not affected. Removing firefox87 flag since this was targeted for Firefox 88.

Comment 8

[:Gijs (he/him)]

We've backed this out of beta to fix the 2 regressions filed about it.