Bug 1723058 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
When running the command via a CDP client the following data is returned by Chrome:

```
>>> Browser.getVersion()
{
  protocolVersion: '1.3',
  product: 'Chrome/92.0.4515.107',
  revision: '@87a818b10553a07434ea9e2b6dccf3cbe7895134',
  userAgent: 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/92.0.4515.107 Safari/537.36',
  jsVersion: '9.2.230.20'
}
```

In our implementation we currently do not return the version information but only the application name with an optional `Headless` prefix:

https://searchfox.org/mozilla-central/source/remote/cdp/domains/parent/Browser.jsm#29

We should use the value from `Services.appinfo.version` and add it as suffix to the `product`.
Revision 1 by
on 
When running the command via a CDP client the following data is returned by Chrome:

```
>>> Browser.getVersion()
{
  protocolVersion: '1.3',
  product: 'Chrome/92.0.4515.107',
  revision: '@87a818b10553a07434ea9e2b6dccf3cbe7895134',
  userAgent: 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/92.0.4515.107 Safari/537.36',
  jsVersion: '9.2.230.20'
}
```

In our implementation we currently do not return the version information but only the application name with an optional `Headless` prefix:

https://searchfox.org/mozilla-central/source/remote/cdp/domains/parent/Browser.jsm#29

We should use the value from `Services.appinfo.version` and add it as suffix to the `product`.

Also the following two tests would have to be updated:

remote/cdp/test/browser/browser_cdp.js
remote/cdp/test/browser/browser_main_target.js

Back to Bug 1723058 Comment 0