Closed
Bug 1723058
Opened 3 years ago
Closed 2 years ago
Browser.getVersion has to return the application version as part of the product
Categories
(Remote Protocol :: CDP, defect, P3)
Remote Protocol
CDP
Tracking
(firefox103 fixed)
RESOLVED
FIXED
103 Branch
| Tracking | Status | |
|---|---|---|
| firefox103 | --- | fixed |
People
(Reporter: whimboo, Assigned: sabina.zaripova, Mentored)
References
()
Details
(Whiteboard: [lang=js])
User Story
See our documentation at https://firefox-source-docs.mozilla.org/remote/index.html in how to get started. Feel free to ask questions at https://chat.mozilla.org/#/room/#remote-protocol:mozilla.org
Attachments
(1 file)
When running the command via a CDP client the following data is returned by Chrome:
>>> Browser.getVersion()
{
protocolVersion: '1.3',
product: 'Chrome/92.0.4515.107',
revision: '@87a818b10553a07434ea9e2b6dccf3cbe7895134',
userAgent: 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/92.0.4515.107 Safari/537.36',
jsVersion: '9.2.230.20'
}
In our implementation we currently do not return the version information but only the application name with an optional Headless prefix:
https://searchfox.org/mozilla-central/source/remote/cdp/domains/parent/Browser.jsm#29
We should use the value from Services.appinfo.version and add it as suffix to the product.
Also the following two tests would have to be updated:
remote/cdp/test/browser/browser_cdp.js
remote/cdp/test/browser/browser_main_target.js
|
Reporter | |
Updated•3 years ago
|
Severity: -- → S3
Priority: -- → P3
|
||
Updated•2 years ago
|
Assignee: nobody → sabina.zaripova
Status: NEW → ASSIGNED
|
|
||
Updated•2 years ago
|
Attachment #9279126 -
Attachment description: Bug 1723058 - add version to product name.r=whimboo → Bug 1723058 - [cdp] Enhance Browser.getVersion with product name including application version.
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b8fe3b97c50a
[cdp] Enhance Browser.getVersion with product name including application version. r=whimboo,webdriver-reviewers
|
||
Comment 3•2 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox103:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 103 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•